From: Christoph Hellwig <hch@lst.de>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>,
Joanne Koong <joannelkoong@gmail.com>,
willy@infradead.org, djwong@kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model
Date: Fri, 26 Jun 2026 07:38:49 +0200 [thread overview]
Message-ID: <20260626053849.GA9597@lst.de> (raw)
In-Reply-To: <e7012eac-d10f-442d-9681-d95a791e3190@linux.alibaba.com>
On Fri, Jun 26, 2026 at 01:35:33PM +0800, Gao Xiang wrote:
> I know it's much better to "show the code" but I also think it's
> useful to comment ideas now rather than later in case that anyone
> is interested so that it could be useful for their adaption.
Sure.
> I hope I could arrange it in my formal todo list, but I've already
> had a bunch of other things (erofs fsdax dedupe support as I told
> to you since it impacts workloads, and some overlayfs improvement
> and more) in my scheduling list.
>
> Although I tend to play with this idea, it's not a blocker on
> my main interested use cases for now. Also see if some
> complicated conversion like btrfs and f2fs can make more related
> developers interested in following this way.
Yeah. But for now I'd like to get the relatively low hanging fruit
done. And Joanne showed that moving from begin/end to an iter is
actually way simpler than I thought by having the iomap_process
helper that still does get callbacks, but which get inlined. So
I'd be really happy to get this done ASAP before we get a lot more
conversions, and also to avoid having a partial transitition where
we need to keep the old ops around for too long.
After that doing the inlining as in patch 3 becomes pretty easy,
so we can do it where it matter like direct I/O. And also once
we are down to a single callback I think we have a better baseline
for your idea.
>
> Thanks,
> Gao Xiang
---end quoted text---
next prev parent reply other threads:[~2026-06-26 5:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 2:47 [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Joanne Koong
2026-06-25 2:47 ` [RFC PATCH v1 1/3] iomap: add ->iomap_next() and iomap_process() helper Joanne Koong
2026-06-25 12:56 ` Christoph Hellwig
2026-06-25 21:03 ` Joanne Koong
2026-06-26 5:12 ` Christoph Hellwig
2026-06-25 2:47 ` [RFC PATCH v1 2/3] xfs: convert read and buffered write iomap ops to ->iomap_next() Joanne Koong
2026-06-25 2:47 ` [RFC PATCH v1 3/3] xfs: example of devirtualizing buffered write iomap callbacks Joanne Koong
2026-06-25 13:00 ` Christoph Hellwig
2026-06-25 20:46 ` Joanne Koong
2026-06-25 3:25 ` [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Gao Xiang
2026-06-25 3:37 ` Gao Xiang
2026-06-25 13:02 ` Christoph Hellwig
2026-06-25 13:21 ` Gao Xiang
2026-06-25 21:33 ` Joanne Koong
2026-06-26 2:22 ` Gao Xiang
2026-06-26 5:10 ` Christoph Hellwig
2026-06-26 5:35 ` Gao Xiang
2026-06-26 5:38 ` Christoph Hellwig [this message]
2026-06-25 13:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626053849.GA9597@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.