Re: Re: Re: Re: [PATCH 3/7] riscv: dts: eswin: eic7700: add pinctrl support

From: Conor Dooley <conor@kernel.org>
To: Yulin Lu <luyulin@eswincomputing.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Pinkesh Vaghela <pinkesh.vaghela@einfochips.com>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	Min Lin <linmin@eswincomputing.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	Darshan Prajapati <darshan.prajapati@einfochips.com>,
	Pritesh Patel <pritesh.patel@einfochips.com>
Subject: Re: Re: Re: Re: [PATCH 3/7] riscv: dts: eswin: eic7700: add pinctrl support
Date: Mon, 29 Jun 2026 16:18:32 +0100	[thread overview]
Message-ID: <20260629-dubiously-hexagon-696813d11478@spud> (raw)
In-Reply-To: <71b4dfcf.7cef.19f12bfffa7.Coremail.luyulin@eswincomputing.com>

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Mon, Jun 29, 2026 at 05:40:00PM +0800, Yulin Lu wrote:
> &gpio1_pins {       /* jtag0_tck repurposed as GPIO input */
> 	bias-disable;
> 	input-enable;
> };
> 
> &gpio2_pins {       /* jtag0_tms repurposed as GPIO output */
> 	bias-disable;
> 	input-disable;
> };
> 
> If we merge them into a single node, a board DTS can only apply one
> configuration to all 4 pins simultaneously:
> 
> &gpio_jtag_pins {
> 	bias-disable;
> 	input-enable;   /* forced onto all 4 pins - no per-pin control */
> };  

Okay, I didn't notice this, sorry.

> 
> This removes the ability for board DTS files to independently configure
> the electrical properties of each pin when they are used as GPIO for
> different purposes.
> 
> We will send a v2 that also fixes two bugs introduced in this patch:
> rgmii0_pins and rgmii1_pins incorrectly specify function = "hdmi"
> instead of "rgmii", and i2s0_pins, i2s1_pins, i2s2_pins specify
> function = "hdmi" instead of "i2s". These would cause the mux
> requests to fail at runtime. 

Sure.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]