Re: [PATCH v5 0/9] pnv/phb5: Update PHB4 to the latest PHB5 spec

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jun 30, 2026 at 03:52:04PM +0530, Saif Abrar wrote:
> Hello Cedric, Michael,
> 
> Is it OK to retain you Rbs in the next v6?
> 
> or would you like to review this v5? (as the patches have evolved since you
> last reviewed.)
> 
> Regards,
> 
> Saif


I took a look again.

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> On 17-06-2026 15:20, Saif Abrar wrote:
> > Hello,
> > This patchset resolves the review comments for v4:
> > https://lore.kernel.org/qemu-devel/20260305060923.3753402-1-saif.abrar@linux.vnet.ibm.com/
> > 
> > Thanks to all the reviewers for their efforts.
> > 
> > Major updates include the following:
> > - Rename to phb5.
> > - New file for common definitions used in tests/qtest/pnv-* files.
> > - Initializing PnvPHB4Class members within class_init method.
> > - Updated IODA3 PCT table max size to 128, each with 2 entries.
> > - Multiple general cleanups.
> > 
> > Tested with 'make check-qtest' , 'make check-functional-ppc64' and 'make check'.
> > 
> > Regards.
> > 
> > Saif Abrar (9):
> >    qtest/phb5: Add testbench for PHB
> >    pnv/phb5: Add reset logic to PHB5
> >    pnv/phb5: Implement sticky reset logic in PHB5
> >    pnv/phb5: Implement read-only and write-only bits of registers
> >    pnv/phb5: Implement write-clear and return 1's on unimplemented reg
> >      read
> >    pnv/phb5: Set link-active status in HPSTAT and LMR registers
> >    pnv/phb5: Set link speed and width in the DLP training control
> >      register
> >    pnv/phb5: Implement IODA PCT table
> >    pnv/phb5: Mask off LSI Source-ID based on number of interrupts
> > 
> >   hw/pci-host/pnv_phb.c               |   1 +
> >   hw/pci-host/pnv_phb4.c              | 581 +++++++++++++++++++++++++---
> >   include/hw/pci-host/pnv_phb4.h      |  16 +-
> >   include/hw/pci-host/pnv_phb4_regs.h |  66 +++-
> >   tests/qtest/meson.build             |   1 +
> >   tests/qtest/pnv-host-i2c-test.c     |  13 +-
> >   tests/qtest/pnv-phb-test.c          | 235 +++++++++++
> >   tests/qtest/pnv-qtest-common.h      |  24 ++
> >   tests/qtest/pnv-xive2-common.h      |   7 +-
> >   9 files changed, 868 insertions(+), 76 deletions(-)
> >   create mode 100644 tests/qtest/pnv-phb-test.c
> >   create mode 100644 tests/qtest/pnv-qtest-common.h
> >