From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>
Subject: [PATCH v1 2/5] hw/misc/aspeed_scu: Drop noisy unhandled read logs for AST2700 SCU/SCUIO
Date: Fri, 3 Jul 2026 06:45:09 +0000 [thread overview]
Message-ID: <20260703064506.937904-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260703064506.937904-1-jamin_lin@aspeedtech.com>
The AST2700 SCU/SCUIO read handlers currently emit LOG_GUEST_ERROR
messages for all registers that are not explicitly handled.
However, most SCU registers are simple read-back registers without
side effects, and do not require explicit handling in the read path.
Returning the stored register value is sufficient.
Emitting "Unhandled read" logs for these cases generates excessive
and misleading noise during normal guest operation, making it harder
to spot real issues.
Remove the default unhandled read logging from the SCU and SCUIO read
handlers to reduce log noise and align with common QEMU device model
behavior for passive registers.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/misc/aspeed_scu.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
index fe731a28bd..ed7f5e648d 100644
--- a/hw/misc/aspeed_scu.c
+++ b/hw/misc/aspeed_scu.c
@@ -849,13 +849,6 @@ static uint64_t aspeed_ast2700_scu_read(void *opaque, hwaddr offset,
return 0;
}
- switch (reg) {
- default:
- qemu_log_mask(LOG_GUEST_ERROR,
- "%s: Unhandled read at offset 0x%" HWADDR_PRIx "\n",
- __func__, offset);
- }
-
trace_aspeed_ast2700_scu_read(offset, size, s->regs[reg]);
return s->regs[reg];
}
@@ -961,13 +954,6 @@ static uint64_t aspeed_ast2700_scuio_read(void *opaque, hwaddr offset,
return 0;
}
- switch (reg) {
- default:
- qemu_log_mask(LOG_GUEST_ERROR,
- "%s: Unhandled read at offset 0x%" HWADDR_PRIx "\n",
- __func__, offset);
- }
-
trace_aspeed_ast2700_scuio_read(offset, size, s->regs[reg]);
return s->regs[reg];
}
--
2.43.0
next prev parent reply other threads:[~2026-07-03 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 6:45 [PATCH v1 0/5] Split miscellaneous changes from AST2700 FC series Jamin Lin
2026-07-03 6:45 ` [PATCH v1 1/5] hw/arm/aspeed_ast27x0-fc: Fix hardware strap settings Jamin Lin
2026-07-03 6:45 ` Jamin Lin [this message]
2026-07-03 6:45 ` [PATCH v1 3/5] hw/misc/aspeed_scu: Add AST2700 SCUIO RNG control and data registers Jamin Lin
2026-07-03 6:45 ` [PATCH v1 4/5] hw/arm/aspeed_ast27x0: Add unimplemented Privilege Controller MMIO regions for SSP/TSP Jamin Lin
2026-07-03 9:25 ` Philippe Mathieu-Daudé
2026-07-03 9:36 ` Jamin Lin
2026-07-03 6:45 ` [PATCH v1 5/5] hw/arm/aspeed_ast27x0: Add unimplemented OTP controller " Jamin Lin
2026-07-03 9:23 ` Philippe Mathieu-Daudé
2026-07-05 10:39 ` [PATCH v1 0/5] Split miscellaneous changes from AST2700 FC series Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703064506.937904-3-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.