Re: [PATCH v1 4/5] hw/arm/aspeed_ast27x0: Add unimplemented Privilege Controller MMIO regions for SSP/TSP

["Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>]

On 3/7/26 08:45, Jamin Lin wrote:
> The AST2700 SSP/TSP firmware accesses Privilege Controller MMIO regions that
> are not yet implemented in QEMU.
> 
> This change adds unimplemented MMIO devices for the Privilege Controller
> blocks and maps them to their corresponding physical addresses in the SSP/TSP
> address space. These stub devices allow QEMU to safely handle firmware
> accesses and prevent spurious exceptions, while accurately reflecting
> the hardware memory map.
> 
> No functional changes.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   include/hw/arm/aspeed_coprocessor.h |  1 +
>   include/hw/arm/aspeed_soc.h         |  2 ++
>   hw/arm/aspeed_ast27x0-ssp.c         | 13 +++++++++++++
>   hw/arm/aspeed_ast27x0-tsp.c         | 13 +++++++++++++
>   4 files changed, 29 insertions(+)


> diff --git a/hw/arm/aspeed_ast27x0-ssp.c b/hw/arm/aspeed_ast27x0-ssp.c
> index b3c4eb1915..1b68e4eb5f 100644
> --- a/hw/arm/aspeed_ast27x0-ssp.c
> +++ b/hw/arm/aspeed_ast27x0-ssp.c
> @@ -22,10 +22,13 @@ static const hwaddr aspeed_soc_ast27x0ssp_memmap[] = {
>       [ASPEED_DEV_SDRAM]     =  0x00000000,
>       [ASPEED_DEV_SRAM0]     =  0x70000000,
>       [ASPEED_DEV_INTC]      =  0x72100000,
> +    [ASPEED_DEV_PRIC0]     =  0x72140000,
>       [ASPEED_DEV_SCU]       =  0x72C02000,
>       [ASPEED_DEV_TIMER1]    =  0x72C10000,
>       [ASPEED_DEV_UART4]     =  0x72C1A000,
>       [ASPEED_DEV_IPC0]      =  0x72C1C000,
> +    [ASPEED_DEV_FMC]       =  0x74000000,
> +    [ASPEED_DEV_PRIC1]     =  0x74100000,
>       [ASPEED_DEV_SCUIO]     =  0x74C02000,
>       [ASPEED_DEV_INTCIO]    =  0x74C18000,
>       [ASPEED_DEV_UART0]     =  0x74C33000,


> diff --git a/hw/arm/aspeed_ast27x0-tsp.c b/hw/arm/aspeed_ast27x0-tsp.c
> index 6098d1aae3..59dcccd511 100644
> --- a/hw/arm/aspeed_ast27x0-tsp.c
> +++ b/hw/arm/aspeed_ast27x0-tsp.c
> @@ -22,10 +22,13 @@ static const hwaddr aspeed_soc_ast27x0tsp_memmap[] = {
>       [ASPEED_DEV_SDRAM]     =  0x00000000,
>       [ASPEED_DEV_SRAM0]     =  0x70000000,
>       [ASPEED_DEV_INTC]      =  0x72100000,
> +    [ASPEED_DEV_PRIC0]     =  0x72140000,
>       [ASPEED_DEV_SCU]       =  0x72C02000,
>       [ASPEED_DEV_TIMER1]    =  0x72C10000,
>       [ASPEED_DEV_UART4]     =  0x72C1A000,
>       [ASPEED_DEV_IPC0]      =  0x72C1C000,
> +    [ASPEED_DEV_FMC]       =  0x74000000,
> +    [ASPEED_DEV_PRIC1]     =  0x74100000,
>       [ASPEED_DEV_SCUIO]     =  0x74C02000,
>       [ASPEED_DEV_INTCIO]    =  0x74C18000,
>       [ASPEED_DEV_UART0]     =  0x74C33000,
It would be clearer to set ASPEED_DEV_FMC in a distinct patch,
otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>