From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, cem@kernel.org, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/6] xfs: don't wrap around quota ids in dqiterate
Date: Wed, 8 Jul 2026 11:14:38 +0200 [thread overview]
Message-ID: <20260708091438.GB5902@lst.de> (raw)
In-Reply-To: <178346726130.1271589.15159357342663936453.stgit@frogsfrogsfrogs>
On Tue, Jul 07, 2026 at 10:03:40PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM noticed that q_id is an unsigned 32-bit variable. If it happens
> to be set to XFS_DQ_ID_MAX due to a filesystem that actually has a dquot
> for ID_MAX, then this addition will truncate to zero and the iteration
> starts over. Fix this by casting to u64.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-07-08 9:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 5:03 [PATCHSET] xfs: LLM-inspired bug fixes, part 1 Darrick J. Wong
2026-07-08 5:03 ` [PATCH 1/6] xfs: don't replace the wrong part of the cow fork Darrick J. Wong
2026-07-08 9:12 ` Christoph Hellwig
2026-07-08 15:25 ` Darrick J. Wong
2026-07-08 17:57 ` Darrick J. Wong
2026-07-09 4:47 ` Christoph Hellwig
2026-07-09 16:45 ` Darrick J. Wong
2026-07-08 5:03 ` [PATCH 2/6] xfs: don't wrap around quota ids in dqiterate Darrick J. Wong
2026-07-08 9:14 ` Christoph Hellwig [this message]
2026-07-08 5:03 ` [PATCH 3/6] xfs: use rtrefcount btree cursor in xchk_xref_is_rt_cow_staging Darrick J. Wong
2026-07-08 9:15 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 4/6] xfs: use the rt version of the cow staging checker Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 5/6] xfs: write the rg superblock when fixing it Darrick J. Wong
2026-07-13 6:41 ` Christoph Hellwig
2026-07-13 21:58 ` Darrick J. Wong
2026-07-14 5:20 ` Christoph Hellwig
2026-07-14 17:59 ` Darrick J. Wong
2026-07-08 5:04 ` [PATCH 6/6] xfs: grab rtrmap btree when checking rgsuper Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708091438.GB5902@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.