From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/6] xfs: don't replace the wrong part of the cow fork
Date: Wed, 8 Jul 2026 08:25:16 -0700 [thread overview]
Message-ID: <20260708152516.GG9392@frogsfrogsfrogs> (raw)
In-Reply-To: <20260708091220.GA5902@lst.de>
On Wed, Jul 08, 2026 at 11:12:20AM +0200, Christoph Hellwig wrote:
> On Tue, Jul 07, 2026 at 10:03:24PM -0700, Darrick J. Wong wrote:
> > static inline void
> > xrep_cow_replace_mapping(
> > + struct xfs_inode *ip,
> > + struct xfs_iext_cursor *icur,
> > + struct xfs_bmbt_irec *got,
> > + struct xfs_bmbt_irec *rep)
>
> This looks like something that should sit in xfs_bmap.c (or at
> least xfs_bmap_util.c) and not in random scrub code.
>
> And I really wonder how we can get good test coverage for this, including
> for the original bug that this tries to address.
I'll post the debug patch I made that hijacks the errortag knob to make
it randomly shrink the range passed to mark_cow_range instead of the
entire iext record.
The original bug that this tries to address was a pile of bug fixes to
the xfs cow code that you posted for 5.1 that we neglected to backport
to 4.14, resulting in corruption of the cow fork mappings.
--D
next prev parent reply other threads:[~2026-07-08 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 5:03 [PATCHSET] xfs: LLM-inspired bug fixes, part 1 Darrick J. Wong
2026-07-08 5:03 ` [PATCH 1/6] xfs: don't replace the wrong part of the cow fork Darrick J. Wong
2026-07-08 9:12 ` Christoph Hellwig
2026-07-08 15:25 ` Darrick J. Wong [this message]
2026-07-08 17:57 ` Darrick J. Wong
2026-07-09 4:47 ` Christoph Hellwig
2026-07-09 16:45 ` Darrick J. Wong
2026-07-08 5:03 ` [PATCH 2/6] xfs: don't wrap around quota ids in dqiterate Darrick J. Wong
2026-07-08 9:14 ` Christoph Hellwig
2026-07-08 5:03 ` [PATCH 3/6] xfs: use rtrefcount btree cursor in xchk_xref_is_rt_cow_staging Darrick J. Wong
2026-07-08 9:15 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 4/6] xfs: use the rt version of the cow staging checker Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 5/6] xfs: write the rg superblock when fixing it Darrick J. Wong
2026-07-13 6:41 ` Christoph Hellwig
2026-07-13 21:58 ` Darrick J. Wong
2026-07-14 5:20 ` Christoph Hellwig
2026-07-14 17:59 ` Darrick J. Wong
2026-07-08 5:04 ` [PATCH 6/6] xfs: grab rtrmap btree when checking rgsuper Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708152516.GG9392@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.