From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
cem@kernel.org, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs: write the rg superblock when fixing it
Date: Tue, 14 Jul 2026 07:20:11 +0200 [thread overview]
Message-ID: <20260714052011.GA31796@lst.de> (raw)
In-Reply-To: <20260713215857.GG7195@frogsfrogsfrogs>
On Mon, Jul 13, 2026 at 02:58:57PM -0700, Darrick J. Wong wrote:
> Hrmm. Right now both superblock scrubbers don't do much for group 0,
> because both buffers are pinned to the xfs_mount, so they assume that
> there's no need to check anything. However, the ondisk super could have
> gotten corrupted (or blown away by fdisk), in which case an immediate
> crash could render the filesystem unmountable.
>
> So, I could (a) teach the super scrubbers to read the primary / rt
> super; and (b) teach them both to log the superblock and bwrite it
> immediately to shorten the window in which this could happen.
>
> What do you think?
I guess the only sensible time to scrub the sb would be early during
mount?
> Also, this patch should be calling xfs_log_sb *after* xfs_trans_getsb,
> so I'll fix that for the repost.
Oops.
next prev parent reply other threads:[~2026-07-14 5:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 5:03 [PATCHSET] xfs: LLM-inspired bug fixes, part 1 Darrick J. Wong
2026-07-08 5:03 ` [PATCH 1/6] xfs: don't replace the wrong part of the cow fork Darrick J. Wong
2026-07-08 9:12 ` Christoph Hellwig
2026-07-08 15:25 ` Darrick J. Wong
2026-07-08 17:57 ` Darrick J. Wong
2026-07-09 4:47 ` Christoph Hellwig
2026-07-09 16:45 ` Darrick J. Wong
2026-07-08 5:03 ` [PATCH 2/6] xfs: don't wrap around quota ids in dqiterate Darrick J. Wong
2026-07-08 9:14 ` Christoph Hellwig
2026-07-08 5:03 ` [PATCH 3/6] xfs: use rtrefcount btree cursor in xchk_xref_is_rt_cow_staging Darrick J. Wong
2026-07-08 9:15 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 4/6] xfs: use the rt version of the cow staging checker Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 5/6] xfs: write the rg superblock when fixing it Darrick J. Wong
2026-07-13 6:41 ` Christoph Hellwig
2026-07-13 21:58 ` Darrick J. Wong
2026-07-14 5:20 ` Christoph Hellwig [this message]
2026-07-08 5:04 ` [PATCH 6/6] xfs: grab rtrmap btree when checking rgsuper Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714052011.GA31796@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.