[PATCH] auxdisplay: panel: Remove unused callback binding code

[PATCH] auxdisplay: panel: Remove unused callback binding code

[Miles Krause]

panel_bind_callback() has been compiled out with #if 0 since it was
introduced and has no callers. Remove the dead function to reduce
maintenance burden.

No functional change.

Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
---
Compile-tested on x86_64 with:

  make O=out allmodconfig
  make O=out W=1 drivers/auxdisplay/panel.o

Sparse-tested with:

  make O=out C=2 CHECK=sparse drivers/auxdisplay/panel.o
---
 drivers/auxdisplay/panel.c | 37 -------------------------------------
 1 file changed, 37 deletions(-)

diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index d8854cf15268..a7dfc53157bc 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -1450,43 +1450,6 @@ static struct logical_input *panel_bind_key(const char *name, const char *press,
 	return key;
 }
 
-#if 0
-/* tries to bind a callback function to the signal name <name>. The function
- * <press_fct> will be called with the <press_data> arg when the signal is
- * activated, and so on for <release_fct>/<release_data>
- * Returns the pointer to the new signal if ok, NULL if the signal could not
- * be bound.
- */
-static struct logical_input *panel_bind_callback(char *name,
-						 void (*press_fct)(int),
-						 int press_data,
-						 void (*release_fct)(int),
-						 int release_data)
-{
-	struct logical_input *callback;
-
-	callback = kmalloc(sizeof(*callback), GFP_KERNEL);
-	if (!callback)
-		return NULL;
-
-	memset(callback, 0, sizeof(struct logical_input));
-	if (!input_name2mask(name, &callback->mask, &callback->value,
-			     &scan_mask_i, &scan_mask_o))
-		return NULL;
-
-	callback->type = INPUT_TYPE_STD;
-	callback->state = INPUT_ST_LOW;
-	callback->rise_time = 1;
-	callback->fall_time = 1;
-	callback->u.std.press_fct = press_fct;
-	callback->u.std.press_data = press_data;
-	callback->u.std.release_fct = release_fct;
-	callback->u.std.release_data = release_data;
-	list_add(&callback->list, &logical_inputs);
-	return callback;
-}
-#endif
-
 static void keypad_init(void)
 {
 	int keynum;

---
base-commit: 30a41cf47aecb4dafb81183b5e046e93498773ff
change-id: 20260712-panel-remove-dead-callback-46b2251e4feb

Best regards,
--  
Miles Krause <mileskrause5200@gmail.com>

[PATCH] auxdisplay: panel: Remove unused callback binding code

[Miles Krause via B4 Relay]

From: Miles Krause <mileskrause5200@gmail.com>

panel_bind_callback() has been compiled out with #if 0 since it was
introduced and has no callers. Remove the dead function to reduce
maintenance burden.

No functional change.

Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
---
Compile-tested on x86_64 with:

  make O=out allmodconfig
  make O=out W=1 drivers/auxdisplay/panel.o

Sparse-tested with:

  make O=out C=2 CHECK=sparse drivers/auxdisplay/panel.o
---
 drivers/auxdisplay/panel.c | 37 -------------------------------------
 1 file changed, 37 deletions(-)

diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index d8854cf15268..a7dfc53157bc 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -1450,43 +1450,6 @@ static struct logical_input *panel_bind_key(const char *name, const char *press,
 	return key;
 }
 
-#if 0
-/* tries to bind a callback function to the signal name <name>. The function
- * <press_fct> will be called with the <press_data> arg when the signal is
- * activated, and so on for <release_fct>/<release_data>
- * Returns the pointer to the new signal if ok, NULL if the signal could not
- * be bound.
- */
-static struct logical_input *panel_bind_callback(char *name,
-						 void (*press_fct)(int),
-						 int press_data,
-						 void (*release_fct)(int),
-						 int release_data)
-{
-	struct logical_input *callback;
-
-	callback = kmalloc(sizeof(*callback), GFP_KERNEL);
-	if (!callback)
-		return NULL;
-
-	memset(callback, 0, sizeof(struct logical_input));
-	if (!input_name2mask(name, &callback->mask, &callback->value,
-			     &scan_mask_i, &scan_mask_o))
-		return NULL;
-
-	callback->type = INPUT_TYPE_STD;
-	callback->state = INPUT_ST_LOW;
-	callback->rise_time = 1;
-	callback->fall_time = 1;
-	callback->u.std.press_fct = press_fct;
-	callback->u.std.press_data = press_data;
-	callback->u.std.release_fct = release_fct;
-	callback->u.std.release_data = release_data;
-	list_add(&callback->list, &logical_inputs);
-	return callback;
-}
-#endif
-
 static void keypad_init(void)
 {
 	int keynum;

---
base-commit: 30a41cf47aecb4dafb81183b5e046e93498773ff
change-id: 20260712-panel-remove-dead-callback-46b2251e4feb

Best regards,
--  
Miles Krause <mileskrause5200@gmail.com>

Re: [PATCH] auxdisplay: panel: Remove unused callback binding code

[Geert Uytterhoeven]

Hi Miles,

Thanks for your patch!

On Mon, 13 Jul 2026 at 03:07, Miles Krause via B4 Relay
<devnull+mileskrause5200.gmail.com@kernel.org> wrote:
> From: Miles Krause <mileskrause5200@gmail.com>
>
> panel_bind_callback() has been compiled out with #if 0 since it was
> introduced and has no callers. Remove the dead function to reduce

FTR, that function was used until commit 630231776da4916e ("Staging:
panel: remove support for smartcards") in v2.6.29.

> maintenance burden.
>
> No functional change.
>
> Signed-off-by: Miles Krause <mileskrause5200@gmail.com>

I do agree it can go. It can be revived from git history when needed.

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] auxdisplay: panel: Remove unused callback binding code

[Willy TARREAU]

On Mon, Jul 13, 2026 at 10:18:21AM +0200, Geert Uytterhoeven wrote:
> Hi Miles,
> 
> Thanks for your patch!
> 
> On Mon, 13 Jul 2026 at 03:07, Miles Krause via B4 Relay
> <devnull+mileskrause5200.gmail.com@kernel.org> wrote:
> > From: Miles Krause <mileskrause5200@gmail.com>
> >
> > panel_bind_callback() has been compiled out with #if 0 since it was
> > introduced and has no callers. Remove the dead function to reduce
> 
> FTR, that function was used until commit 630231776da4916e ("Staging:
> panel: remove support for smartcards") in v2.6.29.
> 
> > maintenance burden.
> >
> > No functional change.
> >
> > Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
> 
> I do agree it can go. It can be revived from git history when needed.
> 
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert

I, too, strongly doubt it will be reused any day.

Acked-by: Willy Tarreau <willy@haproxy.com>

Willy

Re: [PATCH] auxdisplay: panel: Remove unused callback binding code

[Andy Shevchenko]

On Sun, Jul 12, 2026 at 09:07:11PM -0400, Miles Krause via B4 Relay wrote:
> 
> panel_bind_callback() has been compiled out with #if 0 since it was
> introduced and has no callers. Remove the dead function to reduce
> maintenance burden.
> 
> No functional change.

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] auxdisplay: panel: Remove unused callback binding code

[Geert Uytterhoeven]

Hi Andy,

On Mon, 13 Jul 2026 at 13:28, Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
> On Sun, Jul 12, 2026 at 09:07:11PM -0400, Miles Krause via B4 Relay wrote:
> > panel_bind_callback() has been compiled out with #if 0 since it was
> > introduced and has no callers. Remove the dead function to reduce
> > maintenance burden.
> >
> > No functional change.
>
> Pushed to my review and testing queue, thanks!

You forgot to fix the incorrectness in the patch description:

    "FTR, that function was used until commit 630231776da4916e ("Staging:
    panel: remove support for smartcards") in v2.6.29."

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] auxdisplay: panel: Remove unused callback binding code

[Andy Shevchenko]

On Tue, Jul 14, 2026 at 09:11:04AM +0200, Geert Uytterhoeven wrote:
> On Mon, 13 Jul 2026 at 13:28, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Sun, Jul 12, 2026 at 09:07:11PM -0400, Miles Krause via B4 Relay wrote:
> > > panel_bind_callback() has been compiled out with #if 0 since it was
> > > introduced and has no callers. Remove the dead function to reduce
> > > maintenance burden.
> > >
> > > No functional change.
> >
> > Pushed to my review and testing queue, thanks!
> 
> You forgot to fix the incorrectness in the patch description:
> 
>     "FTR, that function was used until commit 630231776da4916e ("Staging:
>     panel: remove support for smartcards") in v2.6.29."

Ah, thanks, updated.

-- 
With Best Regards,
Andy Shevchenko