From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Can Peng <pengcan@kylinos.cn>
Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com,
jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org,
linux@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad5446: fix OF module device table
Date: Wed, 15 Jul 2026 10:11:19 +0200 [thread overview]
Message-ID: <20260715101119.00001b6f@gmail.com> (raw)
In-Reply-To: <20260714091846.136278-1-pengcan@kylinos.cn>
On Tue, 14 Jul 2026 17:18:45 +0800
Can Peng <pengcan@kylinos.cn> wrote:
> The ad5446 I2C driver exports its OF match table with
> MODULE_DEVICE_TABLE(OF, ...).
>
> The device table type is used by modpost when generating module aliases,
> and scripts/mod/file2alias.c matches the lowercase "of" type. Using
> "OF" prevents the OF table from being recognized, so no OF module alias is
> generated for the I2C driver.
>
> Use the lowercase "of" type so OF-based module autoloading works.
>
> Fixes: 876d94024087 ("iio: dac: ad5446: Separate I2C/SPI into different drivers")
> Signed-off-by: Can Peng <pengcan@kylinos.cn>
> ---
This needs a Cc: stable tag, perhaps Jonathan can add it when applying.
FWIW,
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards
CJD
prev parent reply other threads:[~2026-07-15 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:18 [PATCH] iio: dac: ad5446: fix OF module device table Can Peng
2026-07-14 10:47 ` Andy Shevchenko
2026-07-15 8:11 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715101119.00001b6f@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=pengcan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.