[PATCH] iio: dac: ad5446: fix OF module device table

[PATCH] iio: dac: ad5446: fix OF module device table

[Can Peng]

The ad5446 I2C driver exports its OF match table with
MODULE_DEVICE_TABLE(OF, ...).

The device table type is used by modpost when generating module aliases,
and scripts/mod/file2alias.c matches the lowercase "of" type.  Using
"OF" prevents the OF table from being recognized, so no OF module alias is
generated for the I2C driver.

Use the lowercase "of" type so OF-based module autoloading works.

Fixes: 876d94024087 ("iio: dac: ad5446: Separate I2C/SPI into different drivers")
Signed-off-by: Can Peng <pengcan@kylinos.cn>
---
 drivers/iio/dac/ad5446-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad5446-i2c.c b/drivers/iio/dac/ad5446-i2c.c
index 9797fc3e57a9..286695e240c3 100644
--- a/drivers/iio/dac/ad5446-i2c.c
+++ b/drivers/iio/dac/ad5446-i2c.c
@@ -83,7 +83,7 @@ static const struct of_device_id ad5446_i2c_of_ids[] = {
 	{ .compatible = "adi,ad5622", .data = &ad5622_chip_info },
 	{ }
 };
-MODULE_DEVICE_TABLE(OF, ad5446_i2c_of_ids);
+MODULE_DEVICE_TABLE(of, ad5446_i2c_of_ids);
 
 static struct i2c_driver ad5446_i2c_driver = {
 	.driver = {
-- 
2.53.0

Re: [PATCH] iio: dac: ad5446: fix OF module device table

[Andy Shevchenko]

On Tue, Jul 14, 2026 at 05:18:45PM +0800, Can Peng wrote:
> The ad5446 I2C driver exports its OF match table with
> MODULE_DEVICE_TABLE(OF, ...).
> 
> The device table type is used by modpost when generating module aliases,
> and scripts/mod/file2alias.c matches the lowercase "of" type.  Using
> "OF" prevents the OF table from being recognized, so no OF module alias is
> generated for the I2C driver.
> 
> Use the lowercase "of" type so OF-based module autoloading works.

Good catch!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: dac: ad5446: fix OF module device table

[Joshua Crofts]

On Tue, 14 Jul 2026 17:18:45 +0800
Can Peng <pengcan@kylinos.cn> wrote:

> The ad5446 I2C driver exports its OF match table with
> MODULE_DEVICE_TABLE(OF, ...).
> 
> The device table type is used by modpost when generating module aliases,
> and scripts/mod/file2alias.c matches the lowercase "of" type.  Using
> "OF" prevents the OF table from being recognized, so no OF module alias is
> generated for the I2C driver.
> 
> Use the lowercase "of" type so OF-based module autoloading works.
> 
> Fixes: 876d94024087 ("iio: dac: ad5446: Separate I2C/SPI into different drivers")
> Signed-off-by: Can Peng <pengcan@kylinos.cn>
> ---

This needs a Cc: stable tag, perhaps Jonathan can add it when applying.

FWIW,

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards

CJD