Re: [PATCH v3 04/14] perf stat: Extend STD output linter to test core aggregation checks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch omits tests for the `--per-cache` and `--per-cluster` aggregation modes in the new API checks, leaving these modes untested for the new generic print traversal engine.
--

--- Patch [4]: [PATCH v3 04/14] perf stat: Extend STD output linter to test core aggregation checks ---
commit 47016446b8ab80533915b228d12dbc7e4f1bf6a4
Author: Ian Rogers <irogers@google.com>

perf stat: Extend STD output linter to test core aggregation checks
    
This commit extends the stat+std_output.sh script to run standard CPU and 
thread aggregation checks under the --new print flag. It aims to verify the 
standard console outputs produced by the decoupled printing engine across 
core CPU-aggregation modes.

> diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh
> index 233e0a50eb33c..8dee005a72816 100755
> --- a/tools/perf/tests/shell/stat+std_output.sh
> +++ b/tools/perf/tests/shell/stat+std_output.sh
> @@ -121,6 +121,17 @@ fi
>  # New API basic checks
>  perf_cmd="--new -o ${stat_output}"
>  check_no_args "STD (New API)" "$perf_cmd"
> +check_system_wide "STD (New API)" "$perf_cmd"
> +check_interval "STD (New API)" "$perf_cmd"
> +check_per_thread "STD (New API)" "$perf_cmd"
> +check_per_node "STD (New API)" "$perf_cmd"
> +if [ $skip_test -ne 1 ]
> +then
> +	check_system_wide_no_aggr "STD (New API)" "$perf_cmd"
> +	check_per_core "STD (New API)" "$perf_cmd"
> +	check_per_die "STD (New API)" "$perf_cmd"
> +	check_per_socket "STD (New API)" "$perf_cmd"

[Severity: Medium]
Should check_per_cache_instance and check_per_cluster also be included in this
block?

The commit message mentions extending tests for all standard CPU aggregation
checks, but it appears the --per-cache and --per-cluster aggregation modes
were omitted here compared to the older API testing blocks, leaving these
modes untested for the new generic print traversal engine.

> +fi
>  
>  cleanup
>  exit 0

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716043223.388233-1-irogers@google.com?part=4