Re: [PATCH v3 11/14] perf stat: Extend JSON output linter to test core aggregation checks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch omits `check_metric_only`, `check_per_cache_instance`, and `check_per_cluster` from the `--new` API test batch for JSON output.
--

--- Patch [11]: [PATCH v3 11/14] perf stat: Extend JSON output linter to test core aggregation checks ---
commit f2ce77eea150cec3c0f150510510cdbfab125f9f
Author: Ian Rogers <irogers@google.com>

perf stat: Extend JSON output linter to test core aggregation checks

This patch extends the perf stat JSON output tests to run basic and standard
CPU/thread aggregation checks under the --new JSON print flag.

> diff --git a/tools/perf/tests/shell/stat+json_output.sh b/tools/perf/tests/shell/stat+json_output.sh
> --- a/tools/perf/tests/shell/stat+json_output.sh
> +++ b/tools/perf/tests/shell/stat+json_output.sh

[ ... ]

> @@ -232,5 +234,22 @@ then
>  else
>  	echo "[Skip] Skipping tests for system_wide_no_aggr, per_core, per_die and per_socket since socket id exposed via topology is invalid"
>  fi
> +# Run New API JSON basic and standard aggregation checks
> +perf_new_opt="--new"
> +api_label="json (New API)"
> +check_no_args
> +check_system_wide
> +check_interval
> +check_event
> +check_per_thread
> +check_per_node
> +if [ $skip_test -ne 1 ]
> +then
> +	check_system_wide_no_aggr
> +	check_per_core
> +	check_per_die
> +	check_per_socket
> +fi

[Severity: Medium]
Are check_metric_only, check_per_cache_instance, and check_per_cluster
missing from this new API test block?

While the patch title correctly scopes the changes to core aggregation
checks, this appears to leave the JSON format test coverage incomplete
for the new streaming API.

Unlike the STD and CSV formats which received dedicated follow-up patches
for advanced PMU and metric-only checks, it looks like these checks are
left out for the --new JSON format. Could these be added to ensure the new
JSON output mode is fully covered?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716043223.388233-1-irogers@google.com?part=11