Re: [PATCH v3 03/14] perf stat: Extend STD output linter to test basic New API checks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit POSIX headers (`<time.h>`, `<sys/time.h>`, `<sys/resource.h>`) required for struct definitions in `stat-print-std.c`.
--

--- Patch [3]: [PATCH v3 03/14] perf stat: Extend STD output linter to test basic New API checks ---
commit 388aec1d9173e9ef9de1f0a805bf06f934582952
Author: Ian Rogers <irogers@google.com>

perf stat: Extend STD output linter to test basic New API checks

This patch extends the standard console (STD) output linter script
to run the basic no-argument check a second time using the --new print flag.
This ensures that standard console outputs produced by the decoupled
printing callbacks are formally validated by the test suite.

> diff --git a/tools/perf/util/stat-print-std.c b/tools/perf/util/stat-print-std.c
> new file mode 100644
> index 0000000000000..eb841a729e9ec
> --- /dev/null
> +++ b/tools/perf/util/stat-print-std.c
> @@ -0,0 +1,828 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <errno.h>
> +#include <math.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>

[ ... ]

> +#define USEC_PER_SEC 1000000ULL
> +#define NSEC_PER_SEC 1000000000ULL
> +
> +static double timeval2double(struct timeval *t)

[Severity: Low]
Could this cause a build regression by missing explicit includes for POSIX
structures needed to support musl libc?

The code in tools/perf/util/stat-print-std.c uses struct timeval in
timeval2double(), which requires <sys/time.h>. Additionally:
- struct rusage (via ru_data) in print_footer_std() requires <sys/resource.h>
- struct timespec used in perf_stat__print_std() requires <time.h>

Without these explicit POSIX headers, compilation on systems using musl libc
may fail due to incomplete types.

> +{
> +	return t->tv_sec + (double)t->tv_usec / USEC_PER_SEC;
> +}
> +
> +static void print_footer_std(const struct perf_stat_config *config)
> +{
> +	double avg = avg_stats(config->walltime_nsecs_stats) / NSEC_PER_SEC;
> +	FILE *output = config->output;

[ ... ]

> +		if (config->ru_display) {
> +			double ru_utime =
> +				timeval2double((struct timeval *)&config->ru_data.ru_utime);

[ ... ]

> +int perf_stat__print_std(struct evlist *evlist, const struct perf_stat_config *config,
> +			 const struct target *target, const struct timespec *ts, int argc,
> +			 const char **argv)
> +{

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716043223.388233-1-irogers@google.com?part=3