Re: [PATCH v3 03/14] perf c2c: add function view type definitions and helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] symbol_name_equal() incorrectly returns false when both symbol pointers are NULL, breaking the reflexivity property of equivalence relations.
--

--- Patch [3]: [PATCH v3 03/14] perf c2c: add function view type definitions and helpers ---
commit 59fce059d2f2f9e78151ef993b4629ca2917c709
Author: Jiebin Sun <jiebin.sun@intel.com>
Subject: perf c2c: add function view type definitions and helpers

This commit introduces foundational type definitions and helper functions
for the perf c2c function view browser. It adds the perf_c2c_ext and
c2c_function_browser structures, alongside inline accessors and symbol
comparators.

> diff --git a/tools/perf/ui/browsers/c2c-function.c b/tools/perf/ui/browsers/c2c-function.c
> index c50c8ca825c10..1ef5d08e81c39 100644
> --- a/tools/perf/ui/browsers/c2c-function.c
> +++ b/tools/perf/ui/browsers/c2c-function.c

[ ... ]

> +static __maybe_unused inline bool symbol_name_equal(struct symbol *a, struct symbol *b)
> +{
> +	return a && b && arch__compare_symbol_names(a->name, b->name) == 0;

[Severity: Medium]
If both 'a' and 'b' are NULL, this returns false. Does this cause issues
with reflexivity where two identical "unknown" symbols are treated as
distinct?

If this is used for grouping or looking up symbols, it might create
duplicate entries for NULL symbols or cause failed lookups. 

Should this return true if both are NULL, or are NULL symbols guaranteed
never to be compared here?

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717020530.1645123-1-jiebin.sun@intel.com?part=3