From: Greg KH <gregkh@linuxfoundation.org>
To: "Metehan Günen" <metehangnen@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver
Date: Sun, 19 Jul 2026 13:10:47 +0200 [thread overview]
Message-ID: <2026071912-bunkbed-confined-cfe8@gregkh> (raw)
In-Reply-To: <6a5cac92.b39440a8.65068.278c@mx.google.com>
On Sun, Jul 19, 2026 at 03:53:06AM -0700, Metehan Günen wrote:
> On Sat, Jul 18, 2026 at 11:05:30AM +0200, Greg KH wrote:
> > Is that the "normal" user/kernel api for these types of sensors? I
> > thought we had a real api these days, and a vendor one was not generally
> > a good idea as you are just exposing raw hardware design to userspace.
>
> The GXFP5130 communicates using a vendor-specific MP protocol over the
> eSPI mailbox — it is not USB HID-compliant and does not expose a
> standard fingerprint command set. The libfprint plugin that consumes
> this device speaks the protocol directly and handles enrollment and
> matching entirely in userspace, the same model used by other libfprint
> char-device backends (e.g. goodix-55x4, elan-i2c).
>
> I am open to alternative approaches. If there is a preferred kernel-side
> abstraction for this class of device I should be targeting instead,
> please point me to it and I will rework the driver accordingly.
Why does it have to be a kernel driver at all? Can't you just talk to
the device directly from userspace through the spi userspace api
instead?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-19 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 8:14 [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 8:14 ` [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor Metehan Günen
2026-07-18 9:07 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 9:08 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 9:09 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:12 ` Greg KH
2026-07-18 9:12 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 3/4] Documentation/misc-devices: add gxfp5130.rst Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 4/4] MAINTAINERS: add entry for GXFP5130 fingerprint sensor driver Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
2026-07-18 9:05 ` [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI " Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071912-bunkbed-confined-cfe8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metehangnen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.