From: Greg KH <gregkh@linuxfoundation.org>
To: "Metehan Günen" <metehangnen@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver
Date: Sun, 19 Jul 2026 13:12:03 +0200 [thread overview]
Message-ID: <2026071938-referable-sharpness-700a@gregkh> (raw)
In-Reply-To: <6a5cac9a.b39440a8.65068.2953@mx.google.com>
On Sun, Jul 19, 2026 at 03:53:14AM -0700, Metehan Günen wrote:
> On Sat, Jul 18, 2026 at 11:09:43AM +0200, Greg KH wrote:
> > Why add this extra line?
> > Same here, why the extra line?
>
> Script artifact — the patch generation script added a spurious blank
> line before both the source and obj entries. Will fix in v2.
>
> > Please do not roll your own tracing functions, use the in-kernel ones
> > instead.
>
> Agreed. The entire gxfp_trace module will be removed in v2 and replaced
> with dev_dbg() calls throughout, which integrate with the kernel's
> dynamic debug infrastructure.
Or you can use the normal traceing infrastructure if you really want
trace log messages instead of dev_dbg() ones. Your call.
next prev parent reply other threads:[~2026-07-19 11:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 8:14 [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 8:14 ` [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor Metehan Günen
2026-07-18 9:07 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 9:08 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 9:09 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:12 ` Greg KH [this message]
2026-07-18 9:12 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 3/4] Documentation/misc-devices: add gxfp5130.rst Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 4/4] MAINTAINERS: add entry for GXFP5130 fingerprint sensor driver Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
2026-07-18 9:05 ` [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI " Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071938-referable-sharpness-700a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metehangnen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.