From: "Metehan Günen" <metehangnen@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver
Date: Thu, 23 Jul 2026 03:07:52 -0700 (PDT) [thread overview]
Message-ID: <6a61e7f8.e11288f4.4669c.c3b1@mx.google.com> (raw)
In-Reply-To: <2026071842-timing-distress-ad5a@gregkh>
I am withdrawing this patch series (v1).
After consulting with Void755, who wrote the original out-of-tree driver
this submission was based on, it became clear that the driver is not ready
for mainline inclusion yet. Specifically:
- The kernel module currently handles sensor-specific protocol logic
(MP protocol, Goodix command structures) that belongs in userspace.
This is consistent with the concern you raised about why a kernel
driver is needed at all.
- A sibling sensor (SIL6250) shares the same eSPI mailbox transport
mechanism. A properly refactored, transport-only kernel driver could
support both sensors, which would make a stronger case for mainline.
- The original author prefers out-of-tree maintenance for now while
the architecture is reworked.
I will resubmit once the kernel/userspace boundary is properly designed
and the driver is in a state the original author considers ready.
Thank you for the detailed review of v1.
Metehan Günen
prev parent reply other threads:[~2026-07-23 10:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 8:14 [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 8:14 ` [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor Metehan Günen
2026-07-18 9:07 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 9:08 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 9:09 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:12 ` Greg KH
2026-07-18 9:12 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 3/4] Documentation/misc-devices: add gxfp5130.rst Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 4/4] MAINTAINERS: add entry for GXFP5130 fingerprint sensor driver Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
2026-07-18 9:05 ` [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI " Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
2026-07-23 10:07 ` Metehan Günen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a61e7f8.e11288f4.4669c.c3b1@mx.google.com \
--to=metehangnen@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.