Re: [PATCH v6 1/5] arm64: dts: qcom: pmk8550: add VADC node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch includes a non-existent header file `"qcom-adc5-gen3.h"` and uses undefined function-like macros for device tree node registers, which causes a fatal syntax error during device tree compilation.
--

--- Patch [1]: [PATCH v6 1/5] arm64: dts: qcom: pmk8550: add VADC node ---
commit 0e03aa4d4f8680856bf95a8ea645ca19c313f79d
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: pmk8550: add VADC node

This commit adds the VADC node and initial ADC channels for the pmk8550
device tree.

> diff --git a/arch/arm64/boot/dts/qcom/pmk8550.dtsi b/arch/arm64/boot/dts/qcom/pmk8550.dtsi
> --- a/arch/arm64/boot/dts/qcom/pmk8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmk8550.dtsi
> @@ -7,6 +7,7 @@
>  #include <dt-bindings/input/linux-event-codes.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/spmi/spmi.h>
> +#include "qcom-adc5-gen3.h"

[Severity: Low]
Is the qcom-adc5-gen3.h header missing from the tree? Including a file that
does not exist will cause a compilation error.

[ ... ]

> +		pmk8550_vadc: adc@9000 {
> +			compatible = "qcom,spmi-adc5-gen3";
> +			reg = <0x9000>, <0x9100>;
> +			interrupts-extended = <&spmi_bus 0x0 0x90 0x1 IRQ_TYPE_EDGE_RISING>,
> +					      <&spmi_bus 0x0 0x91 0x1 IRQ_TYPE_EDGE_RISING>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#io-channel-cells = <1>;
> +			#thermal-sensor-cells = <1>;
> +
> +			channel@0 {
> +				reg = <ADC5_GEN3_REF_GND(0)>;

[Severity: Low]
Since the header is missing, will the preprocessor fail to expand the
ADC5_GEN3_REF_GND macro? This unexpanded text causes a syntax error when the
device tree compiler expects an integer value.

> +				label = "pmk8550_offset_ref";
> +				qcom,pre-scaling = <1 1>;
> +			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-topic-sm8x50-adc5-gen3-v6-0-a507f4a1e537@linaro.org?part=1