Re: [PATCH v6 3/5] arm64: dts: qcom: sm8550-hdk: add SPMI ADC channels and thermal nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch relies on a missing device tree bindings header `qcom-adc5-gen3.h` and its undefined parameterized macros (e.g., `ADC5_GEN3_DIE_TEMP(1)`), causing a fatal build error during device tree compilation.
--

--- Patch [3]: [PATCH v6 3/5] arm64: dts: qcom: sm8550-hdk: add SPMI ADC channels and thermal nodes ---
commit 2c615238ae0ec9a1d9073743da8ee2dd6a901c3b
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8550-hdk: add SPMI ADC channels and thermal nodes

This patch adds the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the
other PMICs on the system. It also adds thermal nodes sorted by sensor
channel.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index ee13e6136a825..b24c3d902385b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> @@ -280,6 +280,92 @@ platform {
>  		};
>  	};
>  
> +	thermal-zones {
> +		skin-thermal {
> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_THM_100K_PU(1)>;

[Severity: Low]
Does this missing parameterized macro cause a build regression? It looks like
the required device tree bindings header for qcom-adc5-gen3 isn't included
here, which would leave these macros undefined during device tree compilation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-topic-sm8x50-adc5-gen3-v6-0-a507f4a1e537@linaro.org?part=3