Re: [PATCH v6 2/5] arm64: dts: qcom: sm8550-qrd: add SPMI ADC channels and thermal nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing device tree header `qcom-adc5-gen3.h` and undefined parameterized macros cause DT build failures.
--

--- Patch [2]: [PATCH v6 2/5] arm64: dts: qcom: sm8550-qrd: add SPMI ADC channels and thermal nodes ---
commit 10ac856253ee6a9bfd1b29cd5e0fd011493eaf4e
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8550-qrd: add SPMI ADC channels and thermal nodes

Add the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the other PMICS on
the system. The thermal nodes are sorted by the sensor channel to be coherent
with the system thermal nodes ordering.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> index 2fb2e0be5e4c6..f0cee98df35de 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
[ ... ]
> @@ -205,6 +205,92 @@ platform {
>  		};
>  	};
>  
> +	thermal-zones {
> +		skin-thermal {
> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_THM_100K_PU(1)>;

[Severity: Low]
Does this device tree compile cleanly? It looks like the macro 
ADC5_GEN3_AMUX1_THM_100K_PU(1) is parameterized, but the necessary header
(qcom-adc5-gen3.h) doesn't appear to be included or added in this series.

Without the proper header definition, existing parameterless macros might
cause this to expand into invalid syntax like 0x44(1) during the device
tree compilation phase.

[ ... ]
> +	channel@144 {
> +		reg = <ADC5_GEN3_AMUX1_THM_100K_PU(1)>;

[Severity: Low]
Another instance of the parameterized macro usage here. Is there a missing
patch in this series that adds the qcom-adc5-gen3.h header and macro
definitions?

> +		label = "pm8550_msm_therm";
> +		qcom,ratiometric;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-topic-sm8x50-adc5-gen3-v6-0-a507f4a1e537@linaro.org?part=2