From: sashiko-bot@kernel.org
To: "Christian Marangi" <ansuelsmth@gmail.com>
Cc: neil.armstrong@linaro.org, olteanv@gmail.com,
linux-phy@lists.infradead.org, conor+dt@kernel.org,
robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org
Subject: Re: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory
Date: Fri, 24 Jul 2026 18:54:49 +0000 [thread overview]
Message-ID: <20260724185449.8C4001F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724184523.193661-3-ansuelsmth@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added drivers/phy/airoha/Kconfig and drivers/phy/airoha/Makefile are not covered by the MAINTAINERS entry.
--
--- Patch [2]: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory ---
commit 83a3c170a5f0894b166822d36bf49798d65f73e9
Author: Christian Marangi <ansuelsmth@gmail.com>
phy: move and rename Airoha PCIe PHY driver to dedicated directory
This commit moves the Airoha PCIe PHY driver to a dedicated directory and
renames the files to specifically reference the AN7581 SoC. It also adds a
new Kconfig and Makefile to the newly created drivers/phy/airoha/ directory
to support future drivers for different SoCs.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cb7836a27b177..bbfaca572118c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -765,8 +765,8 @@ M: Lorenzo Bianconi <lorenzo@kernel.org>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> F: Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml
> -F: drivers/phy/phy-airoha-pcie-regs.h
> -F: drivers/phy/phy-airoha-pcie.c
> +F: drivers/phy/airoha/phy-an7581-pcie-regs.h
> +F: drivers/phy/airoha/phy-an7581-pcie.c
[Severity: Low]
This isn't a bug, but should the newly created drivers/phy/airoha/Kconfig
and drivers/phy/airoha/Makefile files also be included in this entry?
Currently, get_maintainer.pl might not automatically include the Airoha PCIe
PHY driver maintainers for patches modifying those build files. Could this
entry be simplified to cover the new files by using a directory match like
"F: drivers/phy/airoha/" instead?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260724184523.193661-1-ansuelsmth@gmail.com?part=2
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Christian Marangi" <ansuelsmth@gmail.com>
Cc: neil.armstrong@linaro.org, olteanv@gmail.com,
linux-phy@lists.infradead.org, conor+dt@kernel.org,
robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org
Subject: Re: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory
Date: Fri, 24 Jul 2026 18:54:49 +0000 [thread overview]
Message-ID: <20260724185449.8C4001F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724184523.193661-3-ansuelsmth@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added drivers/phy/airoha/Kconfig and drivers/phy/airoha/Makefile are not covered by the MAINTAINERS entry.
--
--- Patch [2]: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory ---
commit 83a3c170a5f0894b166822d36bf49798d65f73e9
Author: Christian Marangi <ansuelsmth@gmail.com>
phy: move and rename Airoha PCIe PHY driver to dedicated directory
This commit moves the Airoha PCIe PHY driver to a dedicated directory and
renames the files to specifically reference the AN7581 SoC. It also adds a
new Kconfig and Makefile to the newly created drivers/phy/airoha/ directory
to support future drivers for different SoCs.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cb7836a27b177..bbfaca572118c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -765,8 +765,8 @@ M: Lorenzo Bianconi <lorenzo@kernel.org>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> F: Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml
> -F: drivers/phy/phy-airoha-pcie-regs.h
> -F: drivers/phy/phy-airoha-pcie.c
> +F: drivers/phy/airoha/phy-an7581-pcie-regs.h
> +F: drivers/phy/airoha/phy-an7581-pcie.c
[Severity: Low]
This isn't a bug, but should the newly created drivers/phy/airoha/Kconfig
and drivers/phy/airoha/Makefile files also be included in this entry?
Currently, get_maintainer.pl might not automatically include the Airoha PCIe
PHY driver maintainers for patches modifying those build files. Could this
entry be simplified to cover the new files by using a directory match like
"F: drivers/phy/airoha/" instead?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260724184523.193661-1-ansuelsmth@gmail.com?part=2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-07-24 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 18:45 [PATCH v11 0/3] airoha: an7581: USB support Christian Marangi
2026-07-24 18:45 ` Christian Marangi
2026-07-24 18:45 ` [PATCH v11 1/3] dt-bindings: phy: Add documentation for Airoha AN7581 USB PHY Christian Marangi
2026-07-24 18:45 ` Christian Marangi
2026-07-24 20:34 ` Rob Herring (Arm)
2026-07-24 20:34 ` Rob Herring (Arm)
2026-07-24 18:45 ` [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory Christian Marangi
2026-07-24 18:45 ` Christian Marangi
2026-07-24 18:54 ` sashiko-bot [this message]
2026-07-24 18:54 ` sashiko-bot
2026-07-24 18:45 ` [PATCH v11 3/3] phy: airoha: Add support for Airoha AN7581 USB PHY Christian Marangi
2026-07-24 18:45 ` Christian Marangi
2026-07-24 19:01 ` sashiko-bot
2026-07-24 19:01 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724185449.8C4001F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.