All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiaxing Hu <gahing@gahingwoo.com>
To: attinagaoxu@gmail.com
Cc: alchark@gmail.com, maxime.chevallier@bootlin.com,
	chaoyi.chen@rock-chips.com, andrew@lunn.ch,
	netdev@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH net-next 0/3] net: stmmac: dwmac-rk: add RK3576 GMAC 25M refout support
Date: Mon, 27 Jul 2026 19:41:30 +1200	[thread overview]
Message-ID: <20260727074130.1138409-1-gahing@gahingwoo.com> (raw)
In-Reply-To: <20260727021048.3375444-1-attinagaoxu@gmail.com>

Hi Gavin,

We ran into the same thing on the ArmSoM CM5-IO. As Alexey and Maxime
say, the 25 MHz output is a CRU clock muxed to a pin, so the PHY should
enable it, not the GMAC. I sent that for the YT8531:

  https://lore.kernel.org/all/20260719034555.3623003-1-gahing@gahingwoo.com/

It has Andrew's Reviewed-by and is waiting for net-next. On the CM5-IO
the YT8531 comes up at 1000 Mbit/s with no dwmac-rk change and no dwmac
binding change.

Your board has a YT8521, which uses yt8521_probe(), so it needs the same
devm_clk_get_optional_enabled() there rather than in yt8531_probe(). I am
happy to fold YT8521 into my patch, or you can send a small follow-up
once mine lands, whichever the maintainers prefer. The board DTS then
just needs a clocks phandle to the CRU on the PHY node.

Thanks,
Jiaxing

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Jiaxing Hu <gahing@gahingwoo.com>
To: attinagaoxu@gmail.com
Cc: alchark@gmail.com, maxime.chevallier@bootlin.com,
	chaoyi.chen@rock-chips.com, andrew@lunn.ch,
	netdev@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH net-next 0/3] net: stmmac: dwmac-rk: add RK3576 GMAC 25M refout support
Date: Mon, 27 Jul 2026 19:41:30 +1200	[thread overview]
Message-ID: <20260727074130.1138409-1-gahing@gahingwoo.com> (raw)
In-Reply-To: <20260727021048.3375444-1-attinagaoxu@gmail.com>

Hi Gavin,

We ran into the same thing on the ArmSoM CM5-IO. As Alexey and Maxime
say, the 25 MHz output is a CRU clock muxed to a pin, so the PHY should
enable it, not the GMAC. I sent that for the YT8531:

  https://lore.kernel.org/all/20260719034555.3623003-1-gahing@gahingwoo.com/

It has Andrew's Reviewed-by and is waiting for net-next. On the CM5-IO
the YT8531 comes up at 1000 Mbit/s with no dwmac-rk change and no dwmac
binding change.

Your board has a YT8521, which uses yt8521_probe(), so it needs the same
devm_clk_get_optional_enabled() there rather than in yt8531_probe(). I am
happy to fold YT8521 into my patch, or you can send a small follow-up
once mine lands, whichever the maintainers prefer. The board DTS then
just needs a clocks phandle to the CRU on the PHY node.

Thanks,
Jiaxing

  parent reply	other threads:[~2026-07-27  7:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  2:10 [PATCH net-next 0/3] net: stmmac: dwmac-rk: add RK3576 GMAC 25M refout support Gavin Gao
2026-07-27  2:10 ` Gavin Gao
2026-07-27  2:10 ` [PATCH net-next 1/3] dt-bindings: net: rockchip-dwmac: Add 25M refout clock Gavin Gao
2026-07-27  2:10   ` Gavin Gao
2026-07-30  8:27   ` Krzysztof Kozlowski
2026-07-30  8:27     ` Krzysztof Kozlowski
2026-07-30 11:38     ` Gavin Gao
2026-07-30 11:38       ` Gavin Gao
2026-07-30 11:41       ` Krzysztof Kozlowski
2026-07-30 11:41         ` Krzysztof Kozlowski
2026-07-27  2:10 ` [PATCH net-next 2/3] arm64: dts: rockchip: Add RK3576 GMAC 25M refout clocks Gavin Gao
2026-07-27  2:10   ` Gavin Gao
2026-07-30  8:28   ` Krzysztof Kozlowski
2026-07-30  8:28     ` Krzysztof Kozlowski
2026-07-27  2:10 ` [PATCH net-next 3/3] net: stmmac: dwmac-rk: Enable RGMII 25M refout clock Gavin Gao
2026-07-27  2:10   ` Gavin Gao
2026-07-27  7:10 ` [PATCH net-next 0/3] net: stmmac: dwmac-rk: add RK3576 GMAC 25M refout support Maxime Chevallier
2026-07-27  7:10   ` Maxime Chevallier
2026-07-27  7:19   ` Alexey Charkov
2026-07-27  7:19     ` Alexey Charkov
2026-07-27  7:14 ` Alexey Charkov
2026-07-27  7:14   ` Alexey Charkov
2026-07-27  7:21   ` Chaoyi Chen
2026-07-27  7:21     ` Chaoyi Chen
2026-07-27  7:41 ` Jiaxing Hu [this message]
2026-07-27  7:41   ` Jiaxing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727074130.1138409-1-gahing@gahingwoo.com \
    --to=gahing@gahingwoo.com \
    --cc=alchark@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=attinagaoxu@gmail.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.