From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gavin Gao <attinagaoxu@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, heiko@sntech.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
richardcochran@gmail.com, nicolas.frattaroli@collabora.com,
sebastian.reichel@collabora.com, sashal@kernel.org,
alchark@gmail.com, chaoyi.chen@rock-chips.com,
amadeus@jmu.edu.cn, rmk+kernel@armlinux.org.uk,
horms@kernel.org, alok.a.tiwari@oracle.com,
david.wu@rock-chips.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH net-next 2/3] arm64: dts: rockchip: Add RK3576 GMAC 25M refout clocks
Date: Thu, 30 Jul 2026 10:28:10 +0200 [thread overview]
Message-ID: <20260730-complex-funky-angelfish-dc9aad@quoll> (raw)
In-Reply-To: <20260727021048.3375444-3-attinagaoxu@gmail.com>
On Mon, Jul 27, 2026 at 10:10:46AM +0800, Gavin Gao wrote:
> RK3576 provides REFCLKO25M_GMAC0_OUT and REFCLKO25M_GMAC1_OUT clocks
> for the two GMAC instances.
>
> Describe these clocks with the clk_mac_25m_refout clock name so boards
> using RGMII output clock mode can let the MAC driver manage the 25 MHz
> reference output.
>
> Signed-off-by: Gavin Gao <attinagaoxu@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 70e67d4dccb8..f1125c2f88ab 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1692,10 +1692,10 @@ gmac0: ethernet@2a220000 {
> reg = <0x0 0x2a220000 0x0 0x10000>;
> clocks = <&cru CLK_GMAC0_125M_SRC>, <&cru CLK_GMAC0_RMII_CRU>,
> <&cru PCLK_GMAC0>, <&cru ACLK_GMAC0>,
> - <&cru CLK_GMAC0_PTP_REF>;
> + <&cru CLK_GMAC0_PTP_REF>, <&cru REFCLKO25M_GMAC0_OUT>;
> clock-names = "stmmaceth", "clk_mac_ref",
> "pclk_mac", "aclk_mac",
> - "ptp_ref";
> + "ptp_ref", "clk_mac_25m_refout";
Where is clk_mac_refout? Why do you claim this is a different input
(important: INPUT)?
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gavin Gao <attinagaoxu@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, heiko@sntech.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
richardcochran@gmail.com, nicolas.frattaroli@collabora.com,
sebastian.reichel@collabora.com, sashal@kernel.org,
alchark@gmail.com, chaoyi.chen@rock-chips.com,
amadeus@jmu.edu.cn, rmk+kernel@armlinux.org.uk,
horms@kernel.org, alok.a.tiwari@oracle.com,
david.wu@rock-chips.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH net-next 2/3] arm64: dts: rockchip: Add RK3576 GMAC 25M refout clocks
Date: Thu, 30 Jul 2026 10:28:10 +0200 [thread overview]
Message-ID: <20260730-complex-funky-angelfish-dc9aad@quoll> (raw)
In-Reply-To: <20260727021048.3375444-3-attinagaoxu@gmail.com>
On Mon, Jul 27, 2026 at 10:10:46AM +0800, Gavin Gao wrote:
> RK3576 provides REFCLKO25M_GMAC0_OUT and REFCLKO25M_GMAC1_OUT clocks
> for the two GMAC instances.
>
> Describe these clocks with the clk_mac_25m_refout clock name so boards
> using RGMII output clock mode can let the MAC driver manage the 25 MHz
> reference output.
>
> Signed-off-by: Gavin Gao <attinagaoxu@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 70e67d4dccb8..f1125c2f88ab 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1692,10 +1692,10 @@ gmac0: ethernet@2a220000 {
> reg = <0x0 0x2a220000 0x0 0x10000>;
> clocks = <&cru CLK_GMAC0_125M_SRC>, <&cru CLK_GMAC0_RMII_CRU>,
> <&cru PCLK_GMAC0>, <&cru ACLK_GMAC0>,
> - <&cru CLK_GMAC0_PTP_REF>;
> + <&cru CLK_GMAC0_PTP_REF>, <&cru REFCLKO25M_GMAC0_OUT>;
> clock-names = "stmmaceth", "clk_mac_ref",
> "pclk_mac", "aclk_mac",
> - "ptp_ref";
> + "ptp_ref", "clk_mac_25m_refout";
Where is clk_mac_refout? Why do you claim this is a different input
(important: INPUT)?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-30 8:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 2:10 [PATCH net-next 0/3] net: stmmac: dwmac-rk: add RK3576 GMAC 25M refout support Gavin Gao
2026-07-27 2:10 ` Gavin Gao
2026-07-27 2:10 ` [PATCH net-next 1/3] dt-bindings: net: rockchip-dwmac: Add 25M refout clock Gavin Gao
2026-07-27 2:10 ` Gavin Gao
2026-07-30 8:27 ` Krzysztof Kozlowski
2026-07-30 8:27 ` Krzysztof Kozlowski
2026-07-30 11:38 ` Gavin Gao
2026-07-30 11:38 ` Gavin Gao
2026-07-30 11:41 ` Krzysztof Kozlowski
2026-07-30 11:41 ` Krzysztof Kozlowski
2026-07-27 2:10 ` [PATCH net-next 2/3] arm64: dts: rockchip: Add RK3576 GMAC 25M refout clocks Gavin Gao
2026-07-27 2:10 ` Gavin Gao
2026-07-30 8:28 ` Krzysztof Kozlowski [this message]
2026-07-30 8:28 ` Krzysztof Kozlowski
2026-07-27 2:10 ` [PATCH net-next 3/3] net: stmmac: dwmac-rk: Enable RGMII 25M refout clock Gavin Gao
2026-07-27 2:10 ` Gavin Gao
2026-07-27 7:10 ` [PATCH net-next 0/3] net: stmmac: dwmac-rk: add RK3576 GMAC 25M refout support Maxime Chevallier
2026-07-27 7:10 ` Maxime Chevallier
2026-07-27 7:19 ` Alexey Charkov
2026-07-27 7:19 ` Alexey Charkov
2026-07-27 7:14 ` Alexey Charkov
2026-07-27 7:14 ` Alexey Charkov
2026-07-27 7:21 ` Chaoyi Chen
2026-07-27 7:21 ` Chaoyi Chen
2026-07-27 7:41 ` Jiaxing Hu
2026-07-27 7:41 ` Jiaxing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730-complex-funky-angelfish-dc9aad@quoll \
--to=krzk@kernel.org \
--cc=alchark@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alok.a.tiwari@oracle.com \
--cc=amadeus@jmu.edu.cn \
--cc=andrew+netdev@lunn.ch \
--cc=attinagaoxu@gmail.com \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.