Re: [PATCH v7 19/34] pinctrl: airoha: move common definitions to the separate header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit states its intent to move GPIO related register addresses to `airoha-common.h`, but it only copied them, failing to delete the original macro definitions from `pinctrl-airoha.c`.
--

--- Patch [19]: [PATCH v7 19/34] pinctrl: airoha: move common definitions to the separate header ---
commit e0116c883a65c06680c853edf3abcd0498eff60d
Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

pinctrl: airoha: move common definitions to the separate header

Let's move the SoC independent definitions and declarations of structures
required for Airoha SoC-specific pinctrl drivers to a common header. Later
we'll have several SoC-specific drivers, so this step is necessary.

Also move GPIO related register addresses. It's not changed across en7523/
an7581/an7583 chips and will be used by common gpio code.

> diff --git a/drivers/pinctrl/airoha/airoha-common.h b/drivers/pinctrl/airoha/airoha-common.h
> new file mode 100644
> index 0000000000000..40d7e515c09eb
> --- /dev/null
> +++ b/drivers/pinctrl/airoha/airoha-common.h
[ ... ]
> +/* GPIOs */
> +#define REG_GPIO_CTRL				0x0000
> +#define REG_GPIO_DATA				0x0004
> +#define REG_GPIO_INT				0x0008
> +#define REG_GPIO_INT_EDGE			0x000c
> +#define REG_GPIO_INT_LEVEL			0x0010
> +#define REG_GPIO_OE				0x0014
> +#define REG_GPIO_CTRL1				0x0020
> +#define REG_GPIO_CTRL2				0x0060
> +#define REG_GPIO_CTRL3				0x0064

[ ... ]

> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index 6d4b282c21eaf..7cbedb370c977 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
[ ... ]
> @@ -230,6 +190,8 @@
>  #define REG_GPIO_INT_LEVEL			0x0010
>  #define REG_GPIO_OE				0x0014
>  #define REG_GPIO_CTRL1				0x0020
> +#define REG_GPIO_CTRL2				0x0060
> +#define REG_GPIO_CTRL3				0x0064

[Severity: Low]
The commit message mentions moving the GPIO related register addresses to
airoha-common.h, but the original definitions were left in pinctrl-airoha.c.
Could these duplicate definitions be removed from pinctrl-airoha.c to
complete the move as stated in the commit message?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727074234.3761170-1-mikhail.kshevetskiy@iopsys.eu?part=19