From: Peter Zijlstra <peterz@infradead.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: vladimir.murzin@arm.com, catalin.marinas@arm.com,
hca@linux.ibm.com, linux-kernel@vger.kernel.org,
ruanjinjie@huawei.com, yang@os.amperecomputing.com,
maz@kernel.org, will@kernel.org, ardb@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 06/13] arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops
Date: Tue, 28 Jul 2026 18:49:12 +0200 [thread overview]
Message-ID: <20260728164912.GK651302@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <amjQkPyNAsFRJF9I@J2N7QTR9R3>
On Tue, Jul 28, 2026 at 04:53:52PM +0100, Mark Rutland wrote:
> > > +#define ____PCPU_GPRS_BEGIN(gprs, pcp, off, addr) \
> > > + __DEFINE_ASM_GPR_NUMS \
> > > + __DEFINE_ASM_GPR_ALIASES \
> > > + " mov w" off ", #" __VAL_PCPU_GPRS(pcp, off, addr) "\n" \
> > > + " strh w" off ", " gprs "\n" \
> > > + __KERN_ASM_CPU_OFFSET(off) "\n"
> >
> > Can this macro also generate a readable comment for those few of us
> > building the .i file ?
>
> Do you mean for __VAL_PCPU_GPRS, or ____PCPU_GPRS_BEGIN() ?
I was thinking BEGIN, but whatever is easiest, the __VAL thing is only
ever used in BEGIN anyway.
> I can happily add comments for either (and the corresponding ENDs).
Not sure the comment makes sense for end, that's simply storing 0 and
seems clear enough.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, ada.coupriediaz@arm.com,
ardb@kernel.org, catalin.marinas@arm.com, hca@linux.ibm.com,
linux-kernel@vger.kernel.org, maz@kernel.org,
ruanjinjie@huawei.com, vladimir.murzin@arm.com, will@kernel.org,
yang@os.amperecomputing.com
Subject: Re: [RFC PATCH 06/13] arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops
Date: Tue, 28 Jul 2026 18:49:12 +0200 [thread overview]
Message-ID: <20260728164912.GK651302@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <amjQkPyNAsFRJF9I@J2N7QTR9R3>
On Tue, Jul 28, 2026 at 04:53:52PM +0100, Mark Rutland wrote:
> > > +#define ____PCPU_GPRS_BEGIN(gprs, pcp, off, addr) \
> > > + __DEFINE_ASM_GPR_NUMS \
> > > + __DEFINE_ASM_GPR_ALIASES \
> > > + " mov w" off ", #" __VAL_PCPU_GPRS(pcp, off, addr) "\n" \
> > > + " strh w" off ", " gprs "\n" \
> > > + __KERN_ASM_CPU_OFFSET(off) "\n"
> >
> > Can this macro also generate a readable comment for those few of us
> > building the .i file ?
>
> Do you mean for __VAL_PCPU_GPRS, or ____PCPU_GPRS_BEGIN() ?
I was thinking BEGIN, but whatever is easiest, the __VAL thing is only
ever used in BEGIN anyway.
> I can happily add comments for either (and the corresponding ENDs).
Not sure the comment makes sense for end, that's simply storing 0 and
seems clear enough.
next prev parent reply other threads:[~2026-07-28 16:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 12:38 [RFC PATCH 00/13] arm64: Preemptible this_cpu_*() operations Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 01/13] arm64: preempt: Simplify and optimize __preempt_count_dec_and_test() Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 02/13] arm64: preempt: Treat should_resched() as unlikely Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 03/13] arm64: ptrace: Always inline pt_regs_[read,write}_reg() Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 04/13] arm64: percpu: Factor out percpu offset asm Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 05/13] arm64: gpr-num: Add wxN aliases for wN registers Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 06/13] arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 14:19 ` Peter Zijlstra
2026-07-28 14:19 ` Peter Zijlstra
2026-07-28 14:30 ` Peter Zijlstra
2026-07-28 14:30 ` Peter Zijlstra
2026-07-28 16:03 ` Mark Rutland
2026-07-28 16:03 ` Mark Rutland
2026-07-28 16:49 ` Peter Zijlstra
2026-07-28 16:49 ` Peter Zijlstra
2026-07-28 15:53 ` Mark Rutland
2026-07-28 15:53 ` Mark Rutland
2026-07-28 16:46 ` Peter Zijlstra
2026-07-28 16:46 ` Peter Zijlstra
2026-07-28 16:49 ` Peter Zijlstra [this message]
2026-07-28 16:49 ` Peter Zijlstra
2026-07-28 16:51 ` Heiko Carstens
2026-07-28 16:51 ` Heiko Carstens
2026-07-28 12:38 ` [RFC PATCH 07/13] arm64: percpu: Implement preemptible read/write ops Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 21:47 ` David Laight
2026-07-28 21:47 ` David Laight
2026-07-28 22:05 ` David Laight
2026-07-28 22:05 ` David Laight
2026-07-28 12:38 ` [RFC PATCH 08/13] arm64: percpu: Implement preemptible void RMW ops Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 09/13] arm64: percpu: Implement preemptible return " Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 10/13] arm64: percpu: Implement preemptible XCHG ops Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 11/13] arm64: percpu: Implement preemptible CMPXCHG ops Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 12/13] arm64: percpu: Implement preemptible CMPXCHG128 ops Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 13/13] arm64: percpu: Remove _pcp_protect*() wrappers Mark Rutland
2026-07-28 12:38 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728164912.GK651302@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=hca@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.