Re: [PATCH v10 02/26] dt-bindings: ufs: mediatek,ufs: Complete the binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The property `clock-names` is misspelled as `clocks-names` in the MT8192 conditional block, leaving the actual property unconstrained.
--

--- Patch [2]: [PATCH v10 02/26] dt-bindings: ufs: mediatek,ufs: Complete the binding ---
commit 515312405d3e2237cad578f6e9bc085ee3772431
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

dt-bindings: ufs: mediatek,ufs: Complete the binding

This commit updates the MediaTek UFS binding to replace deprecated frequency
tables with operating-points-v2 and adds missing optional resets. It also
corrects the clock definitions for different SoC variants and documents the
required power supplies.

> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> index 15c347f5e6604..e7e360c59ba59 100644
> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml

[ ... ]

> @@ -54,29 +96,41 @@ allOf:

[ ... ]

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mediatek,mt8192-ufshci
> +    then:
>        properties:
>          clocks:
> -          maxItems: 1
> +          minItems: 3
> +          maxItems: 3
> +        clocks-names:
           ^^^^^^^^^^^^

[Severity: Low]
Is there a typo in this property name? It appears to say clocks-names instead
of clock-names. This might leave the actual clock-names property unconstrained
for the MT8192 hardware variant and cause schema validation to miss incorrect
device tree configurations.

> +          minItems: 3
> +          maxItems: 3
> +        avdd09-supply: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-mt8196-ufs-v10-0-bc5ecef202dc@collabora.com?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy