* [PATCH v5 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD
@ 2026-08-01 10:00 Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Gopikrishna Garmidi @ 2026-08-01 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Pankaj Patil
Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Gopikrishna Garmidi, Abel Vesa,
Konrad Dybcio, Dmitry Baryshkov
Qualcomm Kalambo SoC is derived from Mahua SoC with CPU cluster 0
removed,leaving only cluster 1 present.
This series documents the board compatibles and adds the SoC and
Compute Reference Device (CRD) device trees. It also adds the Kalambo
compatible to the UBWC configuration table and allowlists the Kalambo
CRD for QSEECOM to enable access to efivars.
---
Changes in v5:
- Split PDC ranges at 130, 147 and 171 to skip pins 134, 138, 156, 158,
172, 181 and 202, which carry gp_irq_hvm inputs with nothing wired to
them on Kalambo. Reported by Konrad.
- Reword the commit message to describe the PDC difference.
- Picked up R-b tags.
- Link to v4: https://patch.msgid.link/20260730-b4-kalambo-crd-v4-0-e458f8b08114@oss.qualcomm.com
Changes in v4:
- Split PDC range <108 619 22> into <108 619 1> and <111 622 19> to skip
unconnected pins 109 and 110 on Kalambo. All other PDC ranges match Glymur.
- Rebased on next-20260729.
- Link to v3: https://patch.msgid.link/20260727-b4-kalambo-crd-v3-0-25280faceece@oss.qualcomm.com
Changes in v3:
- Delete and redefine the whole cpu-map via the /cpus label.
- pdp0_mbox: one reg entry per line and use '0x0' instead of '0'.
- Rebased on next-20260726.
- Picked up R-b tags.
- Link to v2: https://patch.msgid.link/20260722-b4-kalambo-crd-v2-0-32d4addc1ac9@oss.qualcomm.com
Changes in v2:
- Fix the cpu-map and SCMI perf domain for the single cluster.
- Give the SCP shared-memory window its own IMEM section.
- Rebased on next-20260721.
- Picked up R-b tags.
- Link to v1: https://patch.msgid.link/20260718-b4-kalambo-crd-v1-0-a1069b5a2757@oss.qualcomm.com
---
Gopikrishna Garmidi (5):
dt-bindings: arm: qcom: Document Kalambo SoC and board
arm64: dts: qcom: Add Kalambo SoC
arm64: dts: qcom: Add Kalambo CRD
firmware: qcom: scm: Allow QSEECOM on Kalambo CRD
soc: qcom: ubwc: Add Kalambo UBWC config
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/glymur.dtsi | 4 +-
arch/arm64/boot/dts/qcom/kalambo-crd.dts | 21 +++++
arch/arm64/boot/dts/qcom/kalambo.dtsi | 119 ++++++++++++++++++++++++
drivers/firmware/qcom/qcom_scm.c | 1 +
drivers/soc/qcom/ubwc_config.c | 1 +
7 files changed, 150 insertions(+), 2 deletions(-)
---
base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853
change-id: 20260715-b4-kalambo-crd-86912a03bbd2
Best regards,
--
Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board
2026-08-01 10:00 [PATCH v5 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
@ 2026-08-01 10:00 ` Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Gopikrishna Garmidi @ 2026-08-01 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Pankaj Patil
Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Gopikrishna Garmidi
Qualcomm Kalambo is a derivative of the Mahua SoC with CPU cluster 0
removed, leaving it with just cluster 1. Document the compatible strings
for the Kalambo SoC and the Compute Reference Device (CRD) board based
on it.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index c7c9a9279684..b0c07a57bda6 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -174,6 +174,11 @@ properties:
- qcom,kaanapali-qrd
- const: qcom,kaanapali
+ - items:
+ - enum:
+ - qcom,kalambo-crd
+ - const: qcom,kalambo
+
- items:
- enum:
- qcom,mahua-crd
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 2/5] arm64: dts: qcom: Add Kalambo SoC
2026-08-01 10:00 [PATCH v5 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
@ 2026-08-01 10:00 ` Gopikrishna Garmidi
2026-08-01 10:15 ` sashiko-bot
2026-08-01 10:00 ` [PATCH v5 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Gopikrishna Garmidi @ 2026-08-01 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Pankaj Patil
Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
Abel Vesa, Gopikrishna Garmidi
Introduce support for the Qualcomm Kalambo SoC. It is derived from Mahua
with CPU cluster 0 (cpu0-cpu5) removed, leaving only cluster 1
(cpu6-cpu11). The surviving cluster is re-added in the cpu-map as
cluster0, since the kernel stops scanning at the first missing clusterN
index. cpu6-cpu11 are reassigned to SCMI performance domain 0, as domain
1 is no longer present.
Kalambo uses PDP1 for SCMI transport. The tx shmem (lpri1) sits at
offset 0x200 within imem, pushing the tx region end to 0x380, so the
imem size is overridden accordingly. The rx shmem (lpri0) remains at
offset 0x0. The PDP mailbox registers are overridden to match the
Kalambo SCP firmware.
Kalambo's PDC input mux differs from Glymur. Pins 109 and 110 carry
tsens6 and tsens7 alarms, which are absent on Kalambo, and pins 134,
138, 156, 158, 172, 181 and 202 carry gp_irq_hvm inputs with nothing
wired to them instead of wakeup GPIOs. Override the PDC ranges to
leave those pins unmapped.
Add labels to the cpus and cpu-map nodes in glymur.dtsi to allow derived
SoCs to delete and redefine the cpu-map entirely.
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/glymur.dtsi | 4 +-
arch/arm64/boot/dts/qcom/kalambo.dtsi | 119 ++++++++++++++++++++++++++++++++++
2 files changed, 121 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index 4be7edf894b5..3f1fd0973717 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -36,7 +36,7 @@ / {
#address-cells = <2>;
#size-cells = <2>;
- cpus {
+ cpus: cpus {
#address-cells = <2>;
#size-cells = <0>;
@@ -274,7 +274,7 @@ cpu17: cpu@20500 {
#cooling-cells = <2>;
};
- cpu-map {
+ cpu_map: cpu-map {
cluster0 {
core0 {
cpu = <&cpu0>;
diff --git a/arch/arm64/boot/dts/qcom/kalambo.dtsi b/arch/arm64/boot/dts/qcom/kalambo.dtsi
new file mode 100644
index 000000000000..8e2077d9d0a8
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/kalambo.dtsi
@@ -0,0 +1,119 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "mahua.dtsi"
+
+/delete-node/ &cluster0_pd;
+/delete-node/ &cpu_map;
+/delete-node/ &cpu0;
+/delete-node/ &cpu1;
+/delete-node/ &cpu2;
+/delete-node/ &cpu3;
+/delete-node/ &cpu4;
+/delete-node/ &cpu5;
+/delete-node/ &cpu_pd0;
+/delete-node/ &cpu_pd1;
+/delete-node/ &cpu_pd2;
+/delete-node/ &cpu_pd3;
+/delete-node/ &cpu_pd4;
+/delete-node/ &cpu_pd5;
+/delete-node/ &cpu_scp_lpri1;
+
+&cpu6 {
+ power-domains = <&cpu_pd6>, <&scmi_perf 0>;
+ power-domain-names = "psci", "perf";
+};
+
+&cpu7 {
+ power-domains = <&cpu_pd7>, <&scmi_perf 0>;
+ power-domain-names = "psci", "perf";
+};
+
+&cpu8 {
+ power-domains = <&cpu_pd8>, <&scmi_perf 0>;
+ power-domain-names = "psci", "perf";
+};
+
+&cpu9 {
+ power-domains = <&cpu_pd9>, <&scmi_perf 0>;
+ power-domain-names = "psci", "perf";
+};
+
+&cpu10 {
+ power-domains = <&cpu_pd10>, <&scmi_perf 0>;
+ power-domain-names = "psci", "perf";
+};
+
+&cpu11 {
+ power-domains = <&cpu_pd11>, <&scmi_perf 0>;
+ power-domain-names = "psci", "perf";
+};
+
+&cpus {
+ cpu-map {
+ cluster0 {
+ core0 {
+ cpu = <&cpu6>;
+ };
+
+ core1 {
+ cpu = <&cpu7>;
+ };
+
+ core2 {
+ cpu = <&cpu8>;
+ };
+
+ core3 {
+ cpu = <&cpu9>;
+ };
+
+ core4 {
+ cpu = <&cpu10>;
+ };
+
+ core5 {
+ cpu = <&cpu11>;
+ };
+ };
+ };
+};
+
+&imem {
+ reg = <0x0 0x81e08600 0x0 0x380>;
+ ranges = <0x0 0x0 0x81e08600 0x380>;
+
+ cpu_scp_lpri1: scp-sram-section@200 {
+ compatible = "arm,scmi-shmem";
+ reg = <0x200 0x180>;
+ };
+};
+
+&pdc {
+ qcom,pdc-ranges = <0 745 38>,
+ <40 785 11>,
+ <51 527 4>,
+ <57 533 10>,
+ <70 546 4>,
+ <75 551 18>,
+ <108 619 1>,
+ <111 622 19>,
+ <130 717 4>,
+ <135 722 3>,
+ <139 726 3>,
+ <142 251 5>,
+ <147 796 9>,
+ <157 806 1>,
+ <159 808 4>,
+ <171 4104 1>,
+ <173 4106 8>,
+ <182 4115 20>,
+ <203 4136 4>;
+};
+
+&pdp0_mbox {
+ reg = <0x0 0x17610000 0x0 0x8000>,
+ <0x0 0x1a980000 0x0 0x8000>;
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 3/5] arm64: dts: qcom: Add Kalambo CRD
2026-08-01 10:00 [PATCH v5 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
@ 2026-08-01 10:00 ` Gopikrishna Garmidi
2026-08-01 10:10 ` sashiko-bot
2026-08-01 10:00 ` [PATCH v5 4/5] firmware: qcom: scm: Allow QSEECOM on " Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 5/5] soc: qcom: ubwc: Add Kalambo UBWC config Gopikrishna Garmidi
4 siblings, 1 reply; 8+ messages in thread
From: Gopikrishna Garmidi @ 2026-08-01 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Pankaj Patil
Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio, Dmitry Baryshkov, Abel Vesa, Gopikrishna Garmidi
Introduce support for the CRD based on the Qualcomm Kalambo SoC. Similar
to Mahua, it is pin-to-pin compatible with the Glymur CRD. It reuses the
common CRD board description and drops the PMIC nodes not present on this
design.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/kalambo-crd.dts | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index e05414290d8e..0ea4d6696aee 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -43,6 +43,7 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp454.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9650-rdp488.dtb
dtb-$(CONFIG_ARCH_QCOM) += kaanapali-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += kaanapali-qrd.dtb
+dtb-$(CONFIG_ARCH_QCOM) += kalambo-crd.dtb
dtb-$(CONFIG_ARCH_QCOM) += lemans-evk.dtb
lemans-evk-camera-csi1-imx577-dtbs := lemans-evk.dtb lemans-evk-camera-csi1-imx577.dtbo
diff --git a/arch/arm64/boot/dts/qcom/kalambo-crd.dts b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
new file mode 100644
index 000000000000..b4441807f460
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "kalambo.dtsi"
+#include "glymur-crd.dtsi"
+
+/delete-node/ &pmcx0102_d_e0;
+/delete-node/ &pmcx0102_d0_thermal;
+/delete-node/ &pmh0104_i_e0;
+/delete-node/ &pmh0104_i0_thermal;
+/delete-node/ &pmh0104_j_e0;
+/delete-node/ &pmh0104_j0_thermal;
+
+/ {
+ model = "Qualcomm Technologies, Inc. Kalambo CRD";
+ compatible = "qcom,kalambo-crd", "qcom,kalambo";
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 4/5] firmware: qcom: scm: Allow QSEECOM on Kalambo CRD
2026-08-01 10:00 [PATCH v5 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
` (2 preceding siblings ...)
2026-08-01 10:00 ` [PATCH v5 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
@ 2026-08-01 10:00 ` Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 5/5] soc: qcom: ubwc: Add Kalambo UBWC config Gopikrishna Garmidi
4 siblings, 0 replies; 8+ messages in thread
From: Gopikrishna Garmidi @ 2026-08-01 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Pankaj Patil
Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio, Dmitry Baryshkov, Gopikrishna Garmidi
Add Kalambo CRD board to the QSEECOM allowlist for enabling access to
efivars.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
drivers/firmware/qcom/qcom_scm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index f35f2ee39130..d1cc6c908daa 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -2327,6 +2327,7 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
{ .compatible = "microsoft,romulus15", },
{ .compatible = "qcom,glymur-crd" },
{ .compatible = "qcom,hamoa-iot-evk" },
+ { .compatible = "qcom,kalambo-crd" },
{ .compatible = "qcom,mahua-crd" },
{ .compatible = "qcom,purwa-iot-evk" },
{ .compatible = "qcom,sc8180x-primus" },
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 5/5] soc: qcom: ubwc: Add Kalambo UBWC config
2026-08-01 10:00 [PATCH v5 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
` (3 preceding siblings ...)
2026-08-01 10:00 ` [PATCH v5 4/5] firmware: qcom: scm: Allow QSEECOM on " Gopikrishna Garmidi
@ 2026-08-01 10:00 ` Gopikrishna Garmidi
4 siblings, 0 replies; 8+ messages in thread
From: Gopikrishna Garmidi @ 2026-08-01 10:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Pankaj Patil
Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio, Dmitry Baryshkov, Gopikrishna Garmidi
Qualcomm Kalambo is a derivative of the Mahua SoC and shares the same
Universal Bandwidth Compression (UBWC) configuration. Add the Kalambo
compatible to the UBWC configuration table to enable support.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
drivers/soc/qcom/ubwc_config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index 0209a02c390f..c5f79210ad52 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -112,6 +112,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
{ .compatible = "qcom,eliza", .data = &ubwc_5_0_hbb15 },
{ .compatible = "qcom,glymur", .data = &glymur_data},
{ .compatible = "qcom,kaanapali", .data = &ubwc_6_0_hbb16 },
+ { .compatible = "qcom,kalambo", .data = &glymur_data },
{ .compatible = "qcom,mahua", .data = &glymur_data },
{ .compatible = "qcom,milos", .data = &milos_data },
{ .compatible = "qcom,msm8226", .data = &no_ubwc_data },
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 3/5] arm64: dts: qcom: Add Kalambo CRD
2026-08-01 10:00 ` [PATCH v5 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
@ 2026-08-01 10:10 ` sashiko-bot
0 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-08-01 10:10 UTC (permalink / raw)
To: Gopikrishna Garmidi; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `kalambo-crd.dts` file omits the `&tcsr` voltage supply definitions, leaving PHY reference clocks unpowered and breaking PCIe/USB.
--
--- Patch [3]: [PATCH v5 3/5] arm64: dts: qcom: Add Kalambo CRD ---
commit aae73b91eb59e39dd9b9d1a032d9f7954d0ab45c
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
arm64: dts: qcom: Add Kalambo CRD
This commit introduces support for the CRD based on the Qualcomm Kalambo SoC.
It reuses the common CRD board description from Glymur while dropping PMIC
nodes that are not present on this design.
> diff --git a/arch/arm64/boot/dts/qcom/kalambo-crd.dts b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
> new file mode 100644
> index 0000000000000..b4441807f4602
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
> @@ -0,0 +1,21 @@
[ ... ]
> +/ {
> + model = "Qualcomm Technologies, Inc. Kalambo CRD";
> + compatible = "qcom,kalambo-crd", "qcom,kalambo";
> +};
[Severity: High]
Does this board need a &tcsr node override to provide voltage supply
definitions for the PHY reference clocks?
Since kalambo-crd.dts omits the &tcsr node override, it fails to map the
board's PMIC LDOs (e.g., vreg_l2f_e1_0p83) to the TCSR's vdda-* supply
properties. The clock driver will likely fall back to dummy regulators,
meaning the hardware voltages are never turned on.
Because this board reuses glymur-crd.dtsi (which enables multiple PCIe and
USB nodes) but misses the &tcsr regulator block required by those PHYs
(which is present in sibling boards like glymur-crd.dts and mahua-crd.dts),
will core connectivity features fail to initialize or experience link
timeouts due to unpowered reference clocks?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260801-b4-kalambo-crd-v5-0-22160abacf3d@oss.qualcomm.com?part=3
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/5] arm64: dts: qcom: Add Kalambo SoC
2026-08-01 10:00 ` [PATCH v5 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
@ 2026-08-01 10:15 ` sashiko-bot
0 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-08-01 10:15 UTC (permalink / raw)
To: Gopikrishna Garmidi; +Cc: conor+dt, devicetree, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The bandwidth monitor PMU node for CPU cluster 0 (bwmon_cluster0) is not disabled or deleted, which can cause a boot crash when probed on Kalambo hardware that physically lacks this cluster.
--
--- Patch [2]: [PATCH v5 2/5] arm64: dts: qcom: Add Kalambo SoC ---
commit 9554cda7ec4f38ae39a00604b42c25a1e924c0a8
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
arm64: dts: qcom: Add Kalambo SoC
This commit introduces support for the Qualcomm Kalambo SoC, which is
derived from Mahua. It removes CPU cluster 0 (cpu0-cpu5) and reassigns
the remaining cluster 1 CPUs as cluster 0, alongside adjusting SCMI
transport and PDC input mux pins.
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/kalambo.dtsi b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> new file mode 100644
> index 0000000000000..8e2077d9d0a8a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> @@ -0,0 +1,119 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include "mahua.dtsi"
> +
> +/delete-node/ &cluster0_pd;
> +/delete-node/ &cpu_map;
> +/delete-node/ &cpu0;
> +/delete-node/ &cpu1;
> +/delete-node/ &cpu2;
> +/delete-node/ &cpu3;
> +/delete-node/ &cpu4;
> +/delete-node/ &cpu5;
> +/delete-node/ &cpu_pd0;
> +/delete-node/ &cpu_pd1;
> +/delete-node/ &cpu_pd2;
> +/delete-node/ &cpu_pd3;
> +/delete-node/ &cpu_pd4;
> +/delete-node/ &cpu_pd5;
> +/delete-node/ &cpu_scp_lpri1;
[Severity: High]
Since CPU cluster 0 is removed, does this code also need to disable the
bwmon_cluster0 node to avoid a boot regression?
If the node is left with its implicit status="okay", the qcom,sdm845-bwmon
driver will unconditionally attempt to probe it during boot. Since the
Kalambo hardware physically lacks this cluster, accessing the unclocked
or removed registers can lead to a synchronous external abort (bus fault)
and a kernel panic.
Deleting the node directly with /delete-node/ might cause device tree
compiler errors because bwmon_cluster1 typically references the
&cpu_bwmon_opp_table nested inside bwmon_cluster0. Setting
status = "disabled" for &bwmon_cluster0 here instead would safely prevent
the probe.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260801-b4-kalambo-crd-v5-0-22160abacf3d@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-08-01 10:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-01 10:00 [PATCH v5 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
2026-08-01 10:15 ` sashiko-bot
2026-08-01 10:00 ` [PATCH v5 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
2026-08-01 10:10 ` sashiko-bot
2026-08-01 10:00 ` [PATCH v5 4/5] firmware: qcom: scm: Allow QSEECOM on " Gopikrishna Garmidi
2026-08-01 10:00 ` [PATCH v5 5/5] soc: qcom: ubwc: Add Kalambo UBWC config Gopikrishna Garmidi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.