From: Jeff King <peff@peff.net>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Gusted <gusted@codeberg.org>
Subject: Re: [PATCH 1/4] revision: move bloom keyvec precondition into function
Date: Wed, 5 Aug 2026 16:32:55 -0400 [thread overview]
Message-ID: <20260805203255.GA1010713@coredump.intra.peff.net> (raw)
In-Reply-To: <87wlu44bv3.fsf@emacs.iotcl.com>
On Wed, Aug 05, 2026 at 09:16:00PM +0200, Toon Claes wrote:
> > But nobody ever cares about the difference between "1" and "-1", because
> > the probabilistic data structure means "we could not check" must err on
> > the side of "it might be in the filter".
>
> That's not entirely true. The `count_bloom_filter_false_positive`
> depends on knowing whether the filter said "maybe" or if no filter was
> used at all.
Ah, yeah, you're right. I saw the "== 0" comparison there, but didn't
notice that we later checked it against "== 1".
> That said, the public function might have a boolean interface, while
> the private wrapper still uses the tristate. I'll address in the next
> version.
Yeah, I'd be OK with that. Or leaving it as-is, given that there is a
caller who cares. It might be less subtle if we used symbolic constants,
but that could be done separately (later or never if nobody cares
enough).
-Peff
next prev parent reply other threads:[~2026-08-05 20:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 15:46 [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-07-17 15:46 ` [PATCH 1/4] revision: move bloom keyvec precondition into function Toon Claes
2026-07-18 7:57 ` Jeff King
2026-08-05 19:16 ` Toon Claes
2026-08-05 20:32 ` Jeff King [this message]
2026-07-17 15:47 ` [PATCH 2/4] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-07-17 20:47 ` Junio C Hamano
2026-07-17 23:26 ` Taylor Blau
2026-07-17 15:47 ` [PATCH 3/4] last-modified: check pathspec against Bloom filter first Toon Claes
2026-07-17 23:05 ` Taylor Blau
2026-07-18 8:37 ` Jeff King
2026-07-18 21:22 ` Taylor Blau
2026-07-20 9:42 ` Jeff King
2026-07-17 15:47 ` [PATCH 4/4] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-07-17 19:16 ` Toon Claes
2026-07-18 8:14 ` Jeff King
2026-08-04 22:19 ` Junio C Hamano
2026-08-05 0:43 ` Taylor Blau
2026-08-05 16:01 ` Junio C Hamano
2026-08-05 1:18 ` Jeff King
2026-07-17 23:18 ` Taylor Blau
2026-07-17 19:13 ` [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-08-07 18:26 ` [PATCH v2 0/6] " Toon Claes
2026-08-07 18:26 ` [PATCH v2 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-08-07 18:26 ` [PATCH v2 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-08-07 18:26 ` [PATCH v2 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-08-07 18:26 ` [PATCH v2 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-08-07 18:26 ` [PATCH v2 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-08-07 18:26 ` [PATCH v2 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-08-08 17:07 ` Junio C Hamano
2026-08-31 15:18 ` [PATCH v3 0/6] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-08-31 15:18 ` [PATCH v3 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-08-31 15:18 ` [PATCH v3 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-08-31 15:18 ` [PATCH v3 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-08-31 15:18 ` [PATCH v3 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-08-31 15:18 ` [PATCH v3 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-08-31 15:18 ` [PATCH v3 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-09-01 4:19 ` Junio C Hamano
2026-09-01 9:14 ` Toon Claes
2026-09-01 13:47 ` Junio C Hamano
2026-08-31 21:19 ` [PATCH v3 0/6] last-modified: use the pathspec's Bloom key to pre-filter commits Junio C Hamano
2026-09-01 9:10 ` [PATCH v4 " Toon Claes
2026-09-01 9:10 ` [PATCH v4 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-09-01 9:10 ` [PATCH v4 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-09-01 9:10 ` [PATCH v4 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-09-01 9:10 ` [PATCH v4 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-09-01 9:10 ` [PATCH v4 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-09-01 9:10 ` [PATCH v4 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805203255.GA1010713@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gusted@codeberg.org \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.