All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <ttaylorr@openai.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Gusted <gusted@codeberg.org>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH 4/4] last-modified: keep per-path Bloom filters for wildcard pathspecs
Date: Fri, 17 Jul 2026 18:18:24 -0500	[thread overview]
Message-ID: <alq4QN6CtQMz_pU8@com-79390> (raw)
In-Reply-To: <20260717-toon-speed-up-last-modified-v1-4-410418f18614@iotcl.com>

On Fri, Jul 17, 2026 at 05:47:02PM +0200, Toon Claes wrote:
> Restore `bloom_filter_settings` after prepare_revision_walk() so the
> per-path check keeps working for wildcard pathspecs.

Could we add a test which actually exercises this?

t8020 never writes a commit-graph with --changed-paths, so these new
Bloom paths remain dormant. The existing "last-modified subdir with
wildcard non-recursive" case passes a/* unquoted, so the shell expands
it into literal pathspecs before last-modified sees it.

Writing a changed-path commit-graph and using a genuinely quoted
top-level wildcard, e.g.:

    check_last_modified -r "*"

, would cover the zero-prefix wildcard case here. -r is necessary
since the default max-depth rejects a true wildcard pathspec.

(To be clear, I don't think that there is a correctness issue here,
but I do think we have a gap in test coverage in this patch.)

Thanks,
Taylor


  parent reply	other threads:[~2026-07-17 23:18 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 15:46 [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-07-17 15:46 ` [PATCH 1/4] revision: move bloom keyvec precondition into function Toon Claes
2026-07-18  7:57   ` Jeff King
2026-08-05 19:16     ` Toon Claes
2026-08-05 20:32       ` Jeff King
2026-07-17 15:47 ` [PATCH 2/4] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-07-17 20:47   ` Junio C Hamano
2026-07-17 23:26     ` Taylor Blau
2026-07-17 15:47 ` [PATCH 3/4] last-modified: check pathspec against Bloom filter first Toon Claes
2026-07-17 23:05   ` Taylor Blau
2026-07-18  8:37     ` Jeff King
2026-07-18 21:22       ` Taylor Blau
2026-07-20  9:42         ` Jeff King
2026-07-17 15:47 ` [PATCH 4/4] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-07-17 19:16   ` Toon Claes
2026-07-18  8:14     ` Jeff King
2026-08-04 22:19       ` Junio C Hamano
2026-08-05  0:43         ` Taylor Blau
2026-08-05 16:01           ` Junio C Hamano
2026-08-05  1:18         ` Jeff King
2026-07-17 23:18   ` Taylor Blau [this message]
2026-07-17 19:13 ` [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-08-07 18:26 ` [PATCH v2 0/6] " Toon Claes
2026-08-07 18:26   ` [PATCH v2 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-08-07 18:26   ` [PATCH v2 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-08-07 18:26   ` [PATCH v2 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-08-07 18:26   ` [PATCH v2 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-08-07 18:26   ` [PATCH v2 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-08-07 18:26   ` [PATCH v2 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-08-08 17:07     ` Junio C Hamano
2026-08-31 15:18   ` [PATCH v3 0/6] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-08-31 15:18     ` [PATCH v3 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-08-31 15:18     ` [PATCH v3 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-08-31 15:18     ` [PATCH v3 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-08-31 15:18     ` [PATCH v3 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-08-31 15:18     ` [PATCH v3 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-08-31 15:18     ` [PATCH v3 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-09-01  4:19       ` Junio C Hamano
2026-09-01  9:14         ` Toon Claes
2026-09-01 13:47           ` Junio C Hamano
2026-08-31 21:19     ` [PATCH v3 0/6] last-modified: use the pathspec's Bloom key to pre-filter commits Junio C Hamano
2026-09-01  9:10     ` [PATCH v4 " Toon Claes
2026-09-01  9:10       ` [PATCH v4 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-09-01  9:10       ` [PATCH v4 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-09-01  9:10       ` [PATCH v4 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-09-01  9:10       ` [PATCH v4 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-09-01  9:10       ` [PATCH v4 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-09-01  9:10       ` [PATCH v4 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alq4QN6CtQMz_pU8@com-79390 \
    --to=ttaylorr@openai.com \
    --cc=git@vger.kernel.org \
    --cc=gusted@codeberg.org \
    --cc=peff@peff.net \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.