From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Gusted <gusted@codeberg.org>,
Jeff King <peff@peff.net>, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v3 0/6] last-modified: use the pathspec's Bloom key to pre-filter commits
Date: Mon, 31 Aug 2026 14:19:00 -0700 [thread overview]
Message-ID: <xmqqmru2ugxn.fsf@gitster.g> (raw)
In-Reply-To: <20260831-toon-speed-up-last-modified-v3-0-2bbb864acf93@iotcl.com> (Toon Claes's message of "Mon, 31 Aug 2026 17:18:40 +0200")
Toon Claes <toon@iotcl.com> writes:
> Similar timings are seen across a few other repositories (like GitLab's
> monolith gitlab-org/gitlab).
>
> [1]: https://lore.kernel.org/git/17f356ff-7bfb-47f5-b714-62a95cc8b821@codeberg.org/
> [2]: https://codeberg.org/ziglang/zig
>
> ---
> Changes in v3:
> - Add trace2 "bloom_queries" and use it in test to verify top-level
> wildcard behavior.
> - Link to v2: https://patch.msgid.link/20260807-toon-speed-up-last-modified-v2-0-7d87bbdeaf9b@iotcl.com
Merged to 'seen', pushed the result out, and saw this:
https://github.com/git/git/actions/runs/33429987759/job/99612809093#step:10:1391
It seems that it is reproducible locally with the variable settings
stolen from ci/run-build-and-tests.sh, i.e.,
$ bash
sh-5.3$ export OPENSSL_SHA1_UNSAFE=YesPlease
sh-5.3$ export GIT_TEST_SPLIT_INDEX=yes
sh-5.3$ export GIT_TEST_FULL_IN_PACK_ARRAY=true
sh-5.3$ export GIT_TEST_OE_SIZE=10
sh-5.3$ export GIT_TEST_OE_DELTA_SIZE=5
sh-5.3$ export GIT_TEST_COMMIT_GRAPH=1
sh-5.3$ export GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS=1
sh-5.3$ export GIT_TEST_MULTI_PACK_INDEX=1
sh-5.3$ export GIT_TEST_MULTI_PACK_INDEX_WRITE_INCREMENTAL=1
sh-5.3$ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master
sh-5.3$ export GIT_TEST_NO_WRITE_REV_INDEX=1
sh-5.3$ export GIT_TEST_CHECKOUT_WORKERS=2
sh-5.3$ export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1
sh-5.3$ make T='t8020*' test
and it does reproduce when the topic is tested standalone (I've kept
the base that I have used to queue the previous iteration,
41365c2a9b The 4th batch for Git 2.56).
Ejected out of 'seen' for now.
next prev parent reply other threads:[~2026-08-31 21:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 15:46 [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-07-17 15:46 ` [PATCH 1/4] revision: move bloom keyvec precondition into function Toon Claes
2026-07-18 7:57 ` Jeff King
2026-08-05 19:16 ` Toon Claes
2026-08-05 20:32 ` Jeff King
2026-07-17 15:47 ` [PATCH 2/4] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-07-17 20:47 ` Junio C Hamano
2026-07-17 23:26 ` Taylor Blau
2026-07-17 15:47 ` [PATCH 3/4] last-modified: check pathspec against Bloom filter first Toon Claes
2026-07-17 23:05 ` Taylor Blau
2026-07-18 8:37 ` Jeff King
2026-07-18 21:22 ` Taylor Blau
2026-07-20 9:42 ` Jeff King
2026-07-17 15:47 ` [PATCH 4/4] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-07-17 19:16 ` Toon Claes
2026-07-18 8:14 ` Jeff King
2026-08-04 22:19 ` Junio C Hamano
2026-08-05 0:43 ` Taylor Blau
2026-08-05 16:01 ` Junio C Hamano
2026-08-05 1:18 ` Jeff King
2026-07-17 23:18 ` Taylor Blau
2026-07-17 19:13 ` [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-08-07 18:26 ` [PATCH v2 0/6] " Toon Claes
2026-08-07 18:26 ` [PATCH v2 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-08-07 18:26 ` [PATCH v2 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-08-07 18:26 ` [PATCH v2 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-08-07 18:26 ` [PATCH v2 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-08-07 18:26 ` [PATCH v2 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-08-07 18:26 ` [PATCH v2 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-08-08 17:07 ` Junio C Hamano
2026-08-31 15:18 ` [PATCH v3 0/6] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-08-31 15:18 ` [PATCH v3 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-08-31 15:18 ` [PATCH v3 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-08-31 15:18 ` [PATCH v3 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-08-31 15:18 ` [PATCH v3 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-08-31 15:18 ` [PATCH v3 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-08-31 15:18 ` [PATCH v3 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-09-01 4:19 ` Junio C Hamano
2026-09-01 9:14 ` Toon Claes
2026-09-01 13:47 ` Junio C Hamano
2026-08-31 21:19 ` Junio C Hamano [this message]
2026-09-01 9:10 ` [PATCH v4 0/6] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-09-01 9:10 ` [PATCH v4 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-09-01 9:10 ` [PATCH v4 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-09-01 9:10 ` [PATCH v4 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-09-01 9:10 ` [PATCH v4 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-09-01 9:10 ` [PATCH v4 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-09-01 9:10 ` [PATCH v4 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmru2ugxn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gusted@codeberg.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.