* Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
@ 2026-08-06 11:16 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-08-06 11:16 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com>
References: <20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com>
TO: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Wesley Cheng <quic_wcheng@quicinc.com>
CC: linux-arm-msm@vger.kernel.org
CC: linux-usb@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Hi Krishna,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 5d5fd841c34649f1b09220fe58e59dffd61c447d]
url: https://github.com/intel-lab-lkp/linux/commits/Krishna-Kurapati/dt-bindings-usb-qcom-snps-dwc3-Fix-glymur-binding-for-non-MP-controllers/20260804-205335
base: 5d5fd841c34649f1b09220fe58e59dffd61c447d
patch link: https://lore.kernel.org/r/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387%40oss.qualcomm.com
patch subject: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: arm64-randconfig-2054-20260805 (https://download.01.org/0day-ci/archive/20260806/202608061303.KhJcDj0D-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
dtschema: 2026.7.dev1+g2203c1720
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260806/202608061303.KhJcDj0D-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202608061303.KhJcDj0D-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
arch/arm64/boot/dts/qcom/glymur-crd.dtb: clock-controller@100000 (qcom,glymur-gcc): clocks: [[59, 0], [59, 1], [60], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [61], [62], [63], [64], [0], [0], [0], [0], [0], [0], [0], [0], [0], [65, 0], [66, 0], [67, 0], [68], [0], [69], [0], [0], [0], [0], [0], [0], [0]] is too long
from schema $id: http://devicetree.org/schemas/clock/qcom,glymur-gcc.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a600000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a600000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a600000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a800000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a800000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a800000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a000000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a000000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a000000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a200000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a200000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/glymur-crd.dtb: usb@a200000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
arch/arm64/boot/dts/qcom/glymur-crd.dtb: efuse@361c8000 (qcom,glymur-qfprom): compatible:0: 'qcom,glymur-qfprom' is not one of ['qcom,apq8064-qfprom', 'qcom,apq8084-qfprom', 'qcom,ipq5018-qfprom', 'qcom,ipq5332-qfprom', 'qcom,ipq5424-qfprom', 'qcom,ipq6018-qfprom', 'qcom,ipq8064-qfprom', 'qcom,ipq8074-qfprom', 'qcom,ipq9574-qfprom', 'qcom,kaanapali-qfprom', 'qcom,msm8226-qfprom', 'qcom,msm8916-qfprom', 'qcom,msm8917-qfprom', 'qcom,msm8937-qfprom', 'qcom,msm8960-qfprom', 'qcom,msm8974-qfprom', 'qcom,msm8976-qfprom', 'qcom,msm8996-qfprom', 'qcom,msm8998-qfprom', 'qcom,qcm2290-qfprom', 'qcom,qcs404-qfprom', 'qcom,qcs615-qfprom', 'qcom,qcs8300-qfprom', 'qcom,sa8775p-qfprom', 'qcom,sar2130p-qfprom', 'qcom,sc7180-qfprom', 'qcom,sc7280-qfprom', 'qcom,sc8280xp-qfprom', 'qcom,sdm630-qfprom', 'qcom,sdm670-qfprom', 'qcom,sdm845-qfprom', 'qcom,sm6115-qfprom', 'qcom,sm6350-qfprom', 'qcom,sm6375-qfprom', 'qcom,sm8150-qfprom', 'qcom,sm8250-qfprom', 'qcom,sm8450-qfprom', 'qcom,sm8550-qfprom', 'qcom,sm8650-qfprom', 'qcom,sm8750-qfprom', 'qcom,x1e80100-qfprom']
from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml
arch/arm64/boot/dts/qcom/glymur-crd.dtb: /soc@0/efuse@361c8000: failed to match any schema with compatible: ['qcom,glymur-qfprom', 'qcom,qfprom']
--
arch/arm64/boot/dts/qcom/mahua-crd.dtb: clock-controller@100000 (qcom,glymur-gcc): clocks: [[45, 0], [45, 1], [46], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [0], [47], [48], [49], [50], [0], [0], [0], [0], [0], [0], [0], [0], [0], [51, 0], [52, 0], [53, 0], [54], [0], [55], [0], [0], [0], [0], [0], [0], [0]] is too long
from schema $id: http://devicetree.org/schemas/clock/qcom,glymur-gcc.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a600000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a600000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a600000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a800000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a800000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a800000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a000000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a000000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a000000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a200000 (qcom,glymur-dwc3): interrupt-names:2: 'hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a200000 (qcom,glymur-dwc3): interrupt-names:3: 'dp_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
>> arch/arm64/boot/dts/qcom/mahua-crd.dtb: usb@a200000 (qcom,glymur-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
arch/arm64/boot/dts/qcom/mahua-crd.dtb: efuse@361c8000 (qcom,glymur-qfprom): compatible:0: 'qcom,glymur-qfprom' is not one of ['qcom,apq8064-qfprom', 'qcom,apq8084-qfprom', 'qcom,ipq5018-qfprom', 'qcom,ipq5332-qfprom', 'qcom,ipq5424-qfprom', 'qcom,ipq6018-qfprom', 'qcom,ipq8064-qfprom', 'qcom,ipq8074-qfprom', 'qcom,ipq9574-qfprom', 'qcom,kaanapali-qfprom', 'qcom,msm8226-qfprom', 'qcom,msm8916-qfprom', 'qcom,msm8917-qfprom', 'qcom,msm8937-qfprom', 'qcom,msm8960-qfprom', 'qcom,msm8974-qfprom', 'qcom,msm8976-qfprom', 'qcom,msm8996-qfprom', 'qcom,msm8998-qfprom', 'qcom,qcm2290-qfprom', 'qcom,qcs404-qfprom', 'qcom,qcs615-qfprom', 'qcom,qcs8300-qfprom', 'qcom,sa8775p-qfprom', 'qcom,sar2130p-qfprom', 'qcom,sc7180-qfprom', 'qcom,sc7280-qfprom', 'qcom,sc8280xp-qfprom', 'qcom,sdm630-qfprom', 'qcom,sdm670-qfprom', 'qcom,sdm845-qfprom', 'qcom,sm6115-qfprom', 'qcom,sm6350-qfprom', 'qcom,sm6375-qfprom', 'qcom,sm8150-qfprom', 'qcom,sm8250-qfprom', 'qcom,sm8450-qfprom', 'qcom,sm8550-qfprom', 'qcom,sm8650-qfprom', 'qcom,sm8750-qfprom', 'qcom,x1e80100-qfprom']
from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml
arch/arm64/boot/dts/qcom/mahua-crd.dtb: /soc@0/efuse@361c8000: failed to match any schema with compatible: ['qcom,glymur-qfprom', 'qcom,qfprom']
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
@ 2026-08-03 4:13 Krishna Kurapati
2026-08-03 4:24 ` sashiko-bot
2026-08-05 7:35 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Krishna Kurapati @ 2026-08-03 4:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wesley Cheng
Cc: Krzysztof Kozlowski, linux-arm-msm, linux-usb, devicetree,
linux-kernel, Krishna Kurapati
Glymur DRD capable controllers have HS Phy interrupt. Fix the binding to
indicate the same.
Fixes: b9d87b41f96f ("dt-bindings: usb: qcom,snps-dwc3: Add Glymur compatible")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index d410aeaf92fb..100a287ea46c 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -524,7 +524,6 @@ allOf:
compatible:
contains:
enum:
- - qcom,glymur-dwc3
- qcom,milos-dwc3
- qcom,x1e80100-dwc3
then:
@@ -547,6 +546,7 @@ allOf:
contains:
enum:
- qcom,eliza-dwc3
+ - qcom,glymur-dwc3
- qcom,ipq4019-dwc3
- qcom,ipq8064-dwc3
- qcom,kaanapali-dwc3
---
base-commit: 5d5fd841c34649f1b09220fe58e59dffd61c447d
change-id: 20260803-glymur-usb-binding-fixes-627471699f35
Best regards,
--
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
2026-08-03 4:13 Krishna Kurapati
@ 2026-08-03 4:24 ` sashiko-bot
2026-08-05 7:35 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-08-03 4:24 UTC (permalink / raw)
To: Krishna Kurapati; +Cc: conor+dt, robh, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Moving `qcom,glymur-dwc3` to a different conditional block enforces a strict interrupt order that breaks schema validation for existing device tree nodes.
--
--- Patch [1]: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers ---
commit 8b1e476813d3e646db74155c4e3c7dfd5ec0b74b
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
Glymur DRD capable controllers have HS Phy interrupt. Fix the binding to
indicate the same.
> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index d410aeaf92fb6..100a287ea46c9 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> @@ -524,7 +524,6 @@ allOf:
> compatible:
> contains:
> enum:
> - - qcom,glymur-dwc3
> - qcom,milos-dwc3
> - qcom,x1e80100-dwc3
> then:
> @@ -547,6 +546,7 @@ allOf:
> contains:
> enum:
> - qcom,eliza-dwc3
> + - qcom,glymur-dwc3
[Severity: Medium]
Will this break dtbs_check for existing in-tree device trees?
Moving qcom,glymur-dwc3 to this block enforces a strict interrupt array
structure where "hs_phy_irq" is required at index 2 (the 3rd item). However,
looking at existing nodes like usb_0 in arch/arm64/boot/dts/qcom/glymur.dtsi:
interrupt-names = "dwc_usb3",
"pwr_event",
"dp_hs_phy_irq",
"dm_hs_phy_irq",
"ss_phy_irq";
This node provides "dp_hs_phy_irq" at index 2 instead.
Additionally, the usb_hs node provides "hs_phy_irq" at the wrong index (4
instead of 2):
interrupt-names = "dwc_usb3",
"pwr_event",
"dp_hs_phy_irq",
"dm_hs_phy_irq",
"hs_phy_irq";
Could we use a oneOf construction or similar to remain backward compatible and
avoid validation regressions for existing nodes?
> - qcom,ipq4019-dwc3
> - qcom,ipq8064-dwc3
> - qcom,kaanapali-dwc3
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
2026-08-03 4:13 Krishna Kurapati
2026-08-03 4:24 ` sashiko-bot
@ 2026-08-05 7:35 ` Krzysztof Kozlowski
2026-08-05 7:42 ` Krishna Kurapati
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-05 7:35 UTC (permalink / raw)
To: Krishna Kurapati
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wesley Cheng, linux-arm-msm, linux-usb, devicetree,
linux-kernel
On Mon, Aug 03, 2026 at 09:43:04AM +0530, Krishna Kurapati wrote:
> Glymur DRD capable controllers have HS Phy interrupt. Fix the binding to
> indicate the same.
HS phy irq is listed in the existing if:then: block, so what do you
exactly fix?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
2026-08-05 7:35 ` Krzysztof Kozlowski
@ 2026-08-05 7:42 ` Krishna Kurapati
0 siblings, 0 replies; 5+ messages in thread
From: Krishna Kurapati @ 2026-08-05 7:42 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wesley Cheng, linux-arm-msm, linux-usb, devicetree,
linux-kernel
On 8/5/2026 1:05 PM, Krzysztof Kozlowski wrote:
> On Mon, Aug 03, 2026 at 09:43:04AM +0530, Krishna Kurapati wrote:
>> Glymur DRD capable controllers have HS Phy interrupt. Fix the binding to
>> indicate the same.
>
> HS phy irq is listed in the existing if:then: block, so what do you
> exactly fix?
>
Hi Krzysztof,
In non-MP SS capable controllers, the HS Phy IRQ is missing from DT.
Also the HS only controller has the dp/dm interrupts swapped up. So
wanted to fix the binding to indicate that the 4 non-MP controllers do
have dwc_usb3/ pwr_event/ dp/ dm/ hs irq all of them.
Regards,
Krishna,
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-06 11:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 11:16 [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-08-03 4:13 Krishna Kurapati
2026-08-03 4:24 ` sashiko-bot
2026-08-05 7:35 ` Krzysztof Kozlowski
2026-08-05 7:42 ` Krishna Kurapati
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.