All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Xu Yang <xu.yang_2@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Chen <peter.chen@kernel.org>,
	Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 02/10] dt-bindings: usb: ci-hdrc-usb2: allow the HSIC PHY as the ULPI child
Date: Mon, 10 Aug 2026 18:42:06 +0300	[thread overview]
Message-ID: <20260810-msm8974-usb-hsic-v1-2-e5f93ea76ffa@oss.qualcomm.com> (raw)
In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com>

The Qualcomm HSIC USB PHY (qcom,usb-hsic-phy.yaml) is a ULPI device: its
driver is a ulpi_driver, so the PHY node must be a child of the chipidea
controller's ulpi node. The ci-hdrc-usb2 schema however hard-codes the
ULPI phy child to the qcom,usb-hs-phy.yaml schema, so any HSIC
controller instance fails validation with bogus clock/reset/compatible
errors.

Allow the ULPI phy child node to match either the HS PHY or the HSIC
PHY schema.

Assisted-by: Claude:claude-fable-5
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
index 620b564914d4..97ebf9e031dd 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
@@ -83,7 +83,9 @@ properties:
       "^phy(-[0-9])?$":
         description: The phy child node for Qcom chips.
         type: object
-        $ref: /schemas/phy/qcom,usb-hs-phy.yaml
+        oneOf:
+          - $ref: /schemas/phy/qcom,usb-hs-phy.yaml
+          - $ref: /schemas/phy/qcom,usb-hsic-phy.yaml
 
 required:
   - compatible

-- 
2.47.3


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Xu Yang <xu.yang_2@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Chen <peter.chen@kernel.org>,
	Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 02/10] dt-bindings: usb: ci-hdrc-usb2: allow the HSIC PHY as the ULPI child
Date: Mon, 10 Aug 2026 18:42:06 +0300	[thread overview]
Message-ID: <20260810-msm8974-usb-hsic-v1-2-e5f93ea76ffa@oss.qualcomm.com> (raw)
In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com>

The Qualcomm HSIC USB PHY (qcom,usb-hsic-phy.yaml) is a ULPI device: its
driver is a ulpi_driver, so the PHY node must be a child of the chipidea
controller's ulpi node. The ci-hdrc-usb2 schema however hard-codes the
ULPI phy child to the qcom,usb-hs-phy.yaml schema, so any HSIC
controller instance fails validation with bogus clock/reset/compatible
errors.

Allow the ULPI phy child node to match either the HS PHY or the HSIC
PHY schema.

Assisted-by: Claude:claude-fable-5
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
index 620b564914d4..97ebf9e031dd 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
@@ -83,7 +83,9 @@ properties:
       "^phy(-[0-9])?$":
         description: The phy child node for Qcom chips.
         type: object
-        $ref: /schemas/phy/qcom,usb-hs-phy.yaml
+        oneOf:
+          - $ref: /schemas/phy/qcom,usb-hs-phy.yaml
+          - $ref: /schemas/phy/qcom,usb-hsic-phy.yaml
 
 required:
   - compatible

-- 
2.47.3


  parent reply	other threads:[~2026-08-10 15:42 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 15:42 [PATCH 00/10] ARM: qcom: msm8974: enable HSIC controller Dmitry Baryshkov
2026-08-10 15:42 ` Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 01/10] dt-bindings: pinctrl: qcom,tlmm-common: allow functions on the HSIC pins Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-20  6:37   ` Krzysztof Kozlowski
2026-08-20  6:37     ` Krzysztof Kozlowski
2026-08-10 15:42 ` Dmitry Baryshkov [this message]
2026-08-10 15:42   ` [PATCH 02/10] dt-bindings: usb: ci-hdrc-usb2: allow the HSIC PHY as the ULPI child Dmitry Baryshkov
2026-08-20  6:33   ` Krzysztof Kozlowski
2026-08-20  6:33     ` Krzysztof Kozlowski
2026-08-10 15:42 ` [PATCH 03/10] phy: qcom-usb-hsic: do not run the sleep calibration clock Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18  9:55   ` Konrad Dybcio
2026-08-18  9:55     ` Konrad Dybcio
2026-08-10 15:42 ` [PATCH 04/10] phy: qcom-usb-hsic: engage HSIC mode from phy_calibrate() Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18  9:57   ` Konrad Dybcio
2026-08-18  9:57     ` Konrad Dybcio
2026-08-10 15:42 ` [PATCH 05/10] usb: chipidea: msm: support the HSIC asynchronous wakeup interrupt Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:36   ` Konrad Dybcio
2026-08-18 10:36     ` Konrad Dybcio
2026-08-19  6:33   ` Peter Chen
2026-08-19  6:33     ` Peter Chen
2026-08-10 15:42 ` [PATCH 06/10] usb: chipidea: msm: keep the glue device runtime-active Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:02   ` Konrad Dybcio
2026-08-18 10:02     ` Konrad Dybcio
2026-08-19  6:43   ` Peter Chen
2026-08-19  6:43     ` Peter Chen
2026-08-10 15:42 ` [PATCH 07/10] usb: chipidea: msm: do not force the TX FIFO idle on HSIC instances Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:08   ` Konrad Dybcio
2026-08-18 10:08     ` Konrad Dybcio
2026-08-19  6:48   ` Peter Chen
2026-08-19  6:48     ` Peter Chen
2026-08-10 15:42 ` [PATCH 08/10] usb: chipidea: host: calibrate the PHY after starting the host Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:09   ` Konrad Dybcio
2026-08-18 10:09     ` Konrad Dybcio
2026-08-19  7:28   ` Peter Chen
2026-08-19  7:28     ` Peter Chen
2026-08-10 15:42 ` [PATCH 09/10] ARM: dts: qcom: msm8974: add the HSIC USB controller Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:16   ` Konrad Dybcio
2026-08-18 10:16     ` Konrad Dybcio
2026-08-20  8:25   ` Abel Vesa
2026-08-20  8:25     ` Abel Vesa
2026-08-10 15:42 ` [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable the HSIC host Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:17   ` Konrad Dybcio
2026-08-18 10:17     ` Konrad Dybcio
2026-08-20  8:24   ` Abel Vesa
2026-08-20  8:24     ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810-msm8974-usb-hsic-v1-2-e5f93ea76ffa@oss.qualcomm.com \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregkh@suse.de \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=peng.fan@nxp.com \
    --cc=peter.chen@kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stephen.boyd@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.