All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Xu Yang <xu.yang_2@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Chen <peter.chen@kernel.org>,
	Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 08/10] usb: chipidea: host: calibrate the PHY after starting the host
Date: Mon, 10 Aug 2026 18:42:12 +0300	[thread overview]
Message-ID: <20260810-msm8974-usb-hsic-v1-8-e5f93ea76ffa@oss.qualcomm.com> (raw)
In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com>

Some PHYs need a final programming step after the host controller is
up: the Qualcomm HSIC PHY latches the device connect at the moment
HSIC mode is engaged, so that write must happen with the root port
already running, or an already-connected HSIC device (the strobe/data
lines have no hotplug) is never seen. The generic PHY framework
provides phy_calibrate() for exactly this kind of post-init fixup and
dwc3 already calls it; the chipidea host does not, leaving no place
for such PHY work.

Call phy_calibrate() once the HCD has been added, next to the existing
i.MX HSIC active-event hook which serves the same purpose. PHYs
without a calibrate op are unaffected.

Assisted-by: Claude:claude-fable-5
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/usb/chipidea/host.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
index ced6076a8248..62bb2999edb6 100644
--- a/drivers/usb/chipidea/host.c
+++ b/drivers/usb/chipidea/host.c
@@ -15,6 +15,7 @@
 #include <linux/regulator/consumer.h>
 #include <linux/string_choices.h>
 #include <linux/pinctrl/consumer.h>
+#include <linux/phy/phy.h>
 
 #include "../host/ehci.h"
 
@@ -192,6 +193,9 @@ static int host_start(struct ci_hdrc *ci)
 			(ci->platdata->flags & CI_HDRC_IMX_IS_HSIC))
 			ci->platdata->notify_event
 				(ci, CI_HDRC_IMX_HSIC_ACTIVE_EVENT);
+
+		if (ci->phy)
+			phy_calibrate(ci->phy);
 	}
 
 	return ret;

-- 
2.47.3


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Xu Yang <xu.yang_2@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Chen <peter.chen@kernel.org>,
	Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 08/10] usb: chipidea: host: calibrate the PHY after starting the host
Date: Mon, 10 Aug 2026 18:42:12 +0300	[thread overview]
Message-ID: <20260810-msm8974-usb-hsic-v1-8-e5f93ea76ffa@oss.qualcomm.com> (raw)
In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com>

Some PHYs need a final programming step after the host controller is
up: the Qualcomm HSIC PHY latches the device connect at the moment
HSIC mode is engaged, so that write must happen with the root port
already running, or an already-connected HSIC device (the strobe/data
lines have no hotplug) is never seen. The generic PHY framework
provides phy_calibrate() for exactly this kind of post-init fixup and
dwc3 already calls it; the chipidea host does not, leaving no place
for such PHY work.

Call phy_calibrate() once the HCD has been added, next to the existing
i.MX HSIC active-event hook which serves the same purpose. PHYs
without a calibrate op are unaffected.

Assisted-by: Claude:claude-fable-5
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/usb/chipidea/host.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
index ced6076a8248..62bb2999edb6 100644
--- a/drivers/usb/chipidea/host.c
+++ b/drivers/usb/chipidea/host.c
@@ -15,6 +15,7 @@
 #include <linux/regulator/consumer.h>
 #include <linux/string_choices.h>
 #include <linux/pinctrl/consumer.h>
+#include <linux/phy/phy.h>
 
 #include "../host/ehci.h"
 
@@ -192,6 +193,9 @@ static int host_start(struct ci_hdrc *ci)
 			(ci->platdata->flags & CI_HDRC_IMX_IS_HSIC))
 			ci->platdata->notify_event
 				(ci, CI_HDRC_IMX_HSIC_ACTIVE_EVENT);
+
+		if (ci->phy)
+			phy_calibrate(ci->phy);
 	}
 
 	return ret;

-- 
2.47.3


  parent reply	other threads:[~2026-08-10 15:42 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 15:42 [PATCH 00/10] ARM: qcom: msm8974: enable HSIC controller Dmitry Baryshkov
2026-08-10 15:42 ` Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 01/10] dt-bindings: pinctrl: qcom,tlmm-common: allow functions on the HSIC pins Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-20  6:37   ` Krzysztof Kozlowski
2026-08-20  6:37     ` Krzysztof Kozlowski
2026-08-10 15:42 ` [PATCH 02/10] dt-bindings: usb: ci-hdrc-usb2: allow the HSIC PHY as the ULPI child Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-20  6:33   ` Krzysztof Kozlowski
2026-08-20  6:33     ` Krzysztof Kozlowski
2026-08-10 15:42 ` [PATCH 03/10] phy: qcom-usb-hsic: do not run the sleep calibration clock Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18  9:55   ` Konrad Dybcio
2026-08-18  9:55     ` Konrad Dybcio
2026-08-10 15:42 ` [PATCH 04/10] phy: qcom-usb-hsic: engage HSIC mode from phy_calibrate() Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18  9:57   ` Konrad Dybcio
2026-08-18  9:57     ` Konrad Dybcio
2026-08-10 15:42 ` [PATCH 05/10] usb: chipidea: msm: support the HSIC asynchronous wakeup interrupt Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:36   ` Konrad Dybcio
2026-08-18 10:36     ` Konrad Dybcio
2026-08-19  6:33   ` Peter Chen
2026-08-19  6:33     ` Peter Chen
2026-08-10 15:42 ` [PATCH 06/10] usb: chipidea: msm: keep the glue device runtime-active Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:02   ` Konrad Dybcio
2026-08-18 10:02     ` Konrad Dybcio
2026-08-19  6:43   ` Peter Chen
2026-08-19  6:43     ` Peter Chen
2026-08-10 15:42 ` [PATCH 07/10] usb: chipidea: msm: do not force the TX FIFO idle on HSIC instances Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:08   ` Konrad Dybcio
2026-08-18 10:08     ` Konrad Dybcio
2026-08-19  6:48   ` Peter Chen
2026-08-19  6:48     ` Peter Chen
2026-08-10 15:42 ` Dmitry Baryshkov [this message]
2026-08-10 15:42   ` [PATCH 08/10] usb: chipidea: host: calibrate the PHY after starting the host Dmitry Baryshkov
2026-08-18 10:09   ` Konrad Dybcio
2026-08-18 10:09     ` Konrad Dybcio
2026-08-19  7:28   ` Peter Chen
2026-08-19  7:28     ` Peter Chen
2026-08-10 15:42 ` [PATCH 09/10] ARM: dts: qcom: msm8974: add the HSIC USB controller Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:16   ` Konrad Dybcio
2026-08-18 10:16     ` Konrad Dybcio
2026-08-20  8:25   ` Abel Vesa
2026-08-20  8:25     ` Abel Vesa
2026-08-10 15:42 ` [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable the HSIC host Dmitry Baryshkov
2026-08-10 15:42   ` Dmitry Baryshkov
2026-08-18 10:17   ` Konrad Dybcio
2026-08-18 10:17     ` Konrad Dybcio
2026-08-20  8:24   ` Abel Vesa
2026-08-20  8:24     ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810-msm8974-usb-hsic-v1-8-e5f93ea76ffa@oss.qualcomm.com \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregkh@suse.de \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=peng.fan@nxp.com \
    --cc=peter.chen@kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stephen.boyd@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.