* [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency
@ 2026-08-10 21:48 Stefan Hajnoczi
2026-08-10 21:54 ` Philippe Mathieu-Daudé
2026-08-11 6:22 ` Klaus Jensen
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2026-08-10 21:48 UTC (permalink / raw)
To: qemu-devel
Cc: Keith Busch, Klaus Jensen, qemu-block, Paolo Bonzini,
Jesper Devantier, Stefan Hajnoczi
The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
a Kconfig dependency to avoid build errors when NVME_PCI is enabled
without SPDM_SOCKET.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/nvme/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
index cfa2ab0f9d5..cfeeed64cd7 100644
--- a/hw/nvme/Kconfig
+++ b/hw/nvme/Kconfig
@@ -2,3 +2,4 @@ config NVME_PCI
bool
default y if PCI_DEVICES || PCIE_DEVICES
depends on PCI
+ select SPDM_SOCKET
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency
2026-08-10 21:48 [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency Stefan Hajnoczi
@ 2026-08-10 21:54 ` Philippe Mathieu-Daudé
2026-08-11 6:22 ` Klaus Jensen
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-08-10 21:54 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Keith Busch, Klaus Jensen, qemu-block, Paolo Bonzini,
Jesper Devantier
On 10/8/26 23:48, Stefan Hajnoczi wrote:
> The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
> a Kconfig dependency to avoid build errors when NVME_PCI is enabled
> without SPDM_SOCKET.
>
Fixes: 4f947b10d52 ("hw/nvme: Add SPDM over DOE support")
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/nvme/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index cfa2ab0f9d5..cfeeed64cd7 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -2,3 +2,4 @@ config NVME_PCI
> bool
> default y if PCI_DEVICES || PCIE_DEVICES
> depends on PCI
> + select SPDM_SOCKET
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency
2026-08-10 21:48 [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency Stefan Hajnoczi
2026-08-10 21:54 ` Philippe Mathieu-Daudé
@ 2026-08-11 6:22 ` Klaus Jensen
2026-08-11 8:31 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Klaus Jensen @ 2026-08-11 6:22 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Keith Busch, qemu-block, Paolo Bonzini,
Jesper Devantier
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Aug 10 17:48, Stefan Hajnoczi wrote:
> The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
> a Kconfig dependency to avoid build errors when NVME_PCI is enabled
> without SPDM_SOCKET.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/nvme/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index cfa2ab0f9d5..cfeeed64cd7 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -2,3 +2,4 @@ config NVME_PCI
> bool
> default y if PCI_DEVICES || PCIE_DEVICES
> depends on PCI
> + select SPDM_SOCKET
> --
> 2.55.0
>
>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Stefan, Philippe,
Do you want to grab this through trivial fixes tree or should I send a
pull?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency
2026-08-11 6:22 ` Klaus Jensen
@ 2026-08-11 8:31 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-08-11 8:31 UTC (permalink / raw)
To: Klaus Jensen, Stefan Hajnoczi
Cc: qemu-devel, Keith Busch, qemu-block, Paolo Bonzini,
Jesper Devantier
On 11/8/26 08:22, Klaus Jensen wrote:
> On Aug 10 17:48, Stefan Hajnoczi wrote:
>> The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
>> a Kconfig dependency to avoid build errors when NVME_PCI is enabled
>> without SPDM_SOCKET.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> hw/nvme/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
>> index cfa2ab0f9d5..cfeeed64cd7 100644
>> --- a/hw/nvme/Kconfig
>> +++ b/hw/nvme/Kconfig
>> @@ -2,3 +2,4 @@ config NVME_PCI
>> bool
>> default y if PCI_DEVICES || PCIE_DEVICES
>> depends on PCI
>> + select SPDM_SOCKET
>> --
>> 2.55.0
>>
>>
>
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
>
> Stefan, Philippe,
>
> Do you want to grab this through trivial fixes tree or should I send a
> pull?
Sure, queued via hw-misc, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-11 8:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-10 21:48 [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency Stefan Hajnoczi
2026-08-10 21:54 ` Philippe Mathieu-Daudé
2026-08-11 6:22 ` Klaus Jensen
2026-08-11 8:31 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.