From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: jaegeuk@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] f2fs: fix to propagate error from f2fs_sync_fs()
Date: Wed, 12 Aug 2026 12:20:43 +0000 [thread overview]
Message-ID: <20260812122043.282195-1-chao@kernel.org> (raw)
So that caller can detect any failure from f2fs_sync_fs().
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/namei.c | 51 ++++++++++++++++++++++++++++++++++---------------
fs/f2fs/super.c | 4 +++-
2 files changed, 39 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index f67864417455..37897f4321c0 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -402,8 +402,11 @@ static int f2fs_create(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -455,8 +458,11 @@ static int f2fs_link(struct dentry *old_dentry, struct inode *dir,
d_instantiate(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
return 0;
out:
clear_inode_flag(inode, FI_INC_LINK);
@@ -624,8 +630,11 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir))
d_invalidate(dentry);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ goto out;
+ }
goto out;
corrupted:
@@ -717,7 +726,7 @@ static int f2fs_symlink(struct mnt_idmap *idmap, struct inode *dir,
disk_link.len - 1);
if (!err && IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ err = f2fs_sync_fs(sbi->sb, 1);
}
if (err)
@@ -769,8 +778,11 @@ static struct dentry *f2fs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return ERR_PTR(err);
+ }
f2fs_balance_fs(sbi, true);
return NULL;
@@ -824,8 +836,11 @@ static int f2fs_mknod(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -1122,8 +1137,11 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
@@ -1289,8 +1307,11 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0c8f60b7242f..3bdb0f891c35 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2960,7 +2960,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)
set_sbi_flag(sbi, SBI_IS_DIRTY);
set_sbi_flag(sbi, SBI_IS_CLOSE);
- f2fs_sync_fs(sb, 1);
+ err = f2fs_sync_fs(sb, 1);
+ if (err)
+ goto restore_gc;
clear_sbi_flag(sbi, SBI_IS_CLOSE);
}
--
2.49.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH] f2fs: fix to propagate error from f2fs_sync_fs()
Date: Wed, 12 Aug 2026 12:20:43 +0000 [thread overview]
Message-ID: <20260812122043.282195-1-chao@kernel.org> (raw)
So that caller can detect any failure from f2fs_sync_fs().
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/namei.c | 51 ++++++++++++++++++++++++++++++++++---------------
fs/f2fs/super.c | 4 +++-
2 files changed, 39 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index f67864417455..37897f4321c0 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -402,8 +402,11 @@ static int f2fs_create(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -455,8 +458,11 @@ static int f2fs_link(struct dentry *old_dentry, struct inode *dir,
d_instantiate(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
return 0;
out:
clear_inode_flag(inode, FI_INC_LINK);
@@ -624,8 +630,11 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir))
d_invalidate(dentry);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ goto out;
+ }
goto out;
corrupted:
@@ -717,7 +726,7 @@ static int f2fs_symlink(struct mnt_idmap *idmap, struct inode *dir,
disk_link.len - 1);
if (!err && IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ err = f2fs_sync_fs(sbi->sb, 1);
}
if (err)
@@ -769,8 +778,11 @@ static struct dentry *f2fs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return ERR_PTR(err);
+ }
f2fs_balance_fs(sbi, true);
return NULL;
@@ -824,8 +836,11 @@ static int f2fs_mknod(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -1122,8 +1137,11 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
@@ -1289,8 +1307,11 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0c8f60b7242f..3bdb0f891c35 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2960,7 +2960,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)
set_sbi_flag(sbi, SBI_IS_DIRTY);
set_sbi_flag(sbi, SBI_IS_CLOSE);
- f2fs_sync_fs(sb, 1);
+ err = f2fs_sync_fs(sb, 1);
+ if (err)
+ goto restore_gc;
clear_sbi_flag(sbi, SBI_IS_CLOSE);
}
--
2.49.0
next reply other threads:[~2026-08-12 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 12:20 Chao Yu via Linux-f2fs-devel [this message]
2026-08-12 12:20 ` [PATCH] f2fs: fix to propagate error from f2fs_sync_fs() Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812122043.282195-1-chao@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.