* [f2fs-dev] [PATCH] f2fs: fix to propagate error from f2fs_sync_fs()
@ 2026-08-12 12:20 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2026-08-12 12:20 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
So that caller can detect any failure from f2fs_sync_fs().
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/namei.c | 51 ++++++++++++++++++++++++++++++++++---------------
fs/f2fs/super.c | 4 +++-
2 files changed, 39 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index f67864417455..37897f4321c0 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -402,8 +402,11 @@ static int f2fs_create(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -455,8 +458,11 @@ static int f2fs_link(struct dentry *old_dentry, struct inode *dir,
d_instantiate(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
return 0;
out:
clear_inode_flag(inode, FI_INC_LINK);
@@ -624,8 +630,11 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir))
d_invalidate(dentry);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ goto out;
+ }
goto out;
corrupted:
@@ -717,7 +726,7 @@ static int f2fs_symlink(struct mnt_idmap *idmap, struct inode *dir,
disk_link.len - 1);
if (!err && IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ err = f2fs_sync_fs(sbi->sb, 1);
}
if (err)
@@ -769,8 +778,11 @@ static struct dentry *f2fs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return ERR_PTR(err);
+ }
f2fs_balance_fs(sbi, true);
return NULL;
@@ -824,8 +836,11 @@ static int f2fs_mknod(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -1122,8 +1137,11 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
@@ -1289,8 +1307,11 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0c8f60b7242f..3bdb0f891c35 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2960,7 +2960,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)
set_sbi_flag(sbi, SBI_IS_DIRTY);
set_sbi_flag(sbi, SBI_IS_CLOSE);
- f2fs_sync_fs(sb, 1);
+ err = f2fs_sync_fs(sb, 1);
+ if (err)
+ goto restore_gc;
clear_sbi_flag(sbi, SBI_IS_CLOSE);
}
--
2.49.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] f2fs: fix to propagate error from f2fs_sync_fs()
@ 2026-08-12 12:20 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2026-08-12 12:20 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu
So that caller can detect any failure from f2fs_sync_fs().
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/namei.c | 51 ++++++++++++++++++++++++++++++++++---------------
fs/f2fs/super.c | 4 +++-
2 files changed, 39 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index f67864417455..37897f4321c0 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -402,8 +402,11 @@ static int f2fs_create(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -455,8 +458,11 @@ static int f2fs_link(struct dentry *old_dentry, struct inode *dir,
d_instantiate(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
return 0;
out:
clear_inode_flag(inode, FI_INC_LINK);
@@ -624,8 +630,11 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir))
d_invalidate(dentry);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ goto out;
+ }
goto out;
corrupted:
@@ -717,7 +726,7 @@ static int f2fs_symlink(struct mnt_idmap *idmap, struct inode *dir,
disk_link.len - 1);
if (!err && IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ err = f2fs_sync_fs(sbi->sb, 1);
}
if (err)
@@ -769,8 +778,11 @@ static struct dentry *f2fs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return ERR_PTR(err);
+ }
f2fs_balance_fs(sbi, true);
return NULL;
@@ -824,8 +836,11 @@ static int f2fs_mknod(struct mnt_idmap *idmap, struct inode *dir,
d_instantiate_new(dentry, inode);
- if (IS_DIRSYNC(dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_balance_fs(sbi, true);
return 0;
@@ -1122,8 +1137,11 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
@@ -1289,8 +1307,11 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
f2fs_unlock_op(sbi, &lc);
- if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
- f2fs_sync_fs(sbi->sb, 1);
+ if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir)) {
+ err = f2fs_sync_fs(sbi->sb, 1);
+ if (err)
+ return err;
+ }
f2fs_update_time(sbi, REQ_TIME);
return 0;
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0c8f60b7242f..3bdb0f891c35 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2960,7 +2960,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)
set_sbi_flag(sbi, SBI_IS_DIRTY);
set_sbi_flag(sbi, SBI_IS_CLOSE);
- f2fs_sync_fs(sb, 1);
+ err = f2fs_sync_fs(sb, 1);
+ if (err)
+ goto restore_gc;
clear_sbi_flag(sbi, SBI_IS_CLOSE);
}
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-12 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-12 12:20 [f2fs-dev] [PATCH] f2fs: fix to propagate error from f2fs_sync_fs() Chao Yu via Linux-f2fs-devel
2026-08-12 12:20 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.