* [PATCH 1/1] ima_setup.sh: Use tst_umount() @ 2026-08-13 11:25 ` Petr Vorel 0 siblings, 0 replies; 11+ messages in thread From: Petr Vorel @ 2026-08-13 11:25 UTC (permalink / raw) To: ltp; +Cc: Petr Vorel, Mimi Zohar, linux-integrity Use standard test mechanism to detect problems during umount() caused by GNOME's gvfsd-trash daemon. Although it will not solve the problem it at least warn tester. Reported-by: Mimi Zohar <zohar@linux.ibm.com> Signed-off-by: Petr Vorel <pvorel@suse.cz> --- testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh index 19f00532b1..054ab28611 100644 --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh @@ -313,7 +313,7 @@ ima_cleanup() [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER for dir in $UMOUNT; do - umount $dir + tst_umount $dir done if [ "$IMA_POLICY_LOADED" = 1 ]; then -- 2.55.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount() @ 2026-08-13 11:25 ` Petr Vorel 0 siblings, 0 replies; 11+ messages in thread From: Petr Vorel @ 2026-08-13 11:25 UTC (permalink / raw) To: ltp; +Cc: linux-integrity Use standard test mechanism to detect problems during umount() caused by GNOME's gvfsd-trash daemon. Although it will not solve the problem it at least warn tester. Reported-by: Mimi Zohar <zohar@linux.ibm.com> Signed-off-by: Petr Vorel <pvorel@suse.cz> --- testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh index 19f00532b1..054ab28611 100644 --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh @@ -313,7 +313,7 @@ ima_cleanup() [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER for dir in $UMOUNT; do - umount $dir + tst_umount $dir done if [ "$IMA_POLICY_LOADED" = 1 ]; then -- 2.55.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [LTP] ima_setup.sh: Use tst_umount() 2026-08-13 11:25 ` [LTP] " Petr Vorel (?) @ 2026-08-13 11:48 ` linuxtestproject.agent -1 siblings, 0 replies; 11+ messages in thread From: linuxtestproject.agent @ 2026-08-13 11:48 UTC (permalink / raw) To: Petr Vorel; +Cc: ltp Hi Petr, On August 13, 2026, Petr Vorel wrote: > ima_setup.sh: Use tst_umount() Verdict - Reviewed --- Note: The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions. Regards, LTP AI Reviewer -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount() 2026-08-13 11:25 ` [LTP] " Petr Vorel @ 2026-08-13 11:54 ` Andrea Cervesato via ltp -1 siblings, 0 replies; 11+ messages in thread From: Andrea Cervesato @ 2026-08-13 11:54 UTC (permalink / raw) To: Petr Vorel; +Cc: ltp, linux-integrity Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato@suse.com ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount() @ 2026-08-13 11:54 ` Andrea Cervesato via ltp 0 siblings, 0 replies; 11+ messages in thread From: Andrea Cervesato via ltp @ 2026-08-13 11:54 UTC (permalink / raw) To: Petr Vorel; +Cc: linux-integrity, ltp Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato@suse.com -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] ima_setup.sh: Use tst_umount() 2026-08-13 11:25 ` [LTP] " Petr Vorel @ 2026-08-14 1:18 ` Mimi Zohar -1 siblings, 0 replies; 11+ messages in thread From: Mimi Zohar @ 2026-08-14 1:18 UTC (permalink / raw) To: Petr Vorel, ltp; +Cc: linux-integrity Hi Petr, On Thu, 2026-08-13 at 13:25 +0200, Petr Vorel wrote: > Use standard test mechanism to detect problems during umount() caused by > GNOME's gvfsd-trash daemon. Although it will not solve the problem it at > least warn tester. > > Reported-by: Mimi Zohar <zohar@linux.ibm.com> > Signed-off-by: Petr Vorel <pvorel@suse.cz> With this patch applied and after removing everything other than ima_violations from /opt/ltp/runtest/ima, I'm still seeing: ima_violations 1 TINFO: $TMPDIR is on tmpfs => run on loop device ima_violations 1 TINFO: booted with IMA policy: tcb ima_violations 1 TINFO: using log /var/log/audit/audit.log ima_violations 1 TINFO: verify open writers violation ima_violations 1 TPASS: 1 open_writers violation(s) added ima_violations 2 TINFO: verify ToMToU violation ima_violations 2 TPASS: 1 ToMToU violation(s) added ima_violations 3 TINFO: verify open_writers using mmapped files tst_kconfig.c:90: TINFO: Parsing kernel config '/lib/modules/7.1.5- 101.fc43.x86_64/build/.config' ima_violations 3 TBROK: tst_checkpoint wait 10000 0 failed umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) failed, try 1 ... ima_violations 3 TINFO: Likely gvfsd-trash is probing newly mounted fs, kill it to speed up tests. umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) failed, try 2 ... The message keeps repeating ... Mimi > --- > testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > index 19f00532b1..054ab28611 100644 > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > @@ -313,7 +313,7 @@ ima_cleanup() > [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER > > for dir in $UMOUNT; do > - umount $dir > + tst_umount $dir > done > > if [ "$IMA_POLICY_LOADED" = 1 ]; then ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount() @ 2026-08-14 1:18 ` Mimi Zohar 0 siblings, 0 replies; 11+ messages in thread From: Mimi Zohar @ 2026-08-14 1:18 UTC (permalink / raw) To: Petr Vorel, ltp; +Cc: linux-integrity Hi Petr, On Thu, 2026-08-13 at 13:25 +0200, Petr Vorel wrote: > Use standard test mechanism to detect problems during umount() caused by > GNOME's gvfsd-trash daemon. Although it will not solve the problem it at > least warn tester. > > Reported-by: Mimi Zohar <zohar@linux.ibm.com> > Signed-off-by: Petr Vorel <pvorel@suse.cz> With this patch applied and after removing everything other than ima_violations from /opt/ltp/runtest/ima, I'm still seeing: ima_violations 1 TINFO: $TMPDIR is on tmpfs => run on loop device ima_violations 1 TINFO: booted with IMA policy: tcb ima_violations 1 TINFO: using log /var/log/audit/audit.log ima_violations 1 TINFO: verify open writers violation ima_violations 1 TPASS: 1 open_writers violation(s) added ima_violations 2 TINFO: verify ToMToU violation ima_violations 2 TPASS: 1 ToMToU violation(s) added ima_violations 3 TINFO: verify open_writers using mmapped files tst_kconfig.c:90: TINFO: Parsing kernel config '/lib/modules/7.1.5- 101.fc43.x86_64/build/.config' ima_violations 3 TBROK: tst_checkpoint wait 10000 0 failed umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) failed, try 1 ... ima_violations 3 TINFO: Likely gvfsd-trash is probing newly mounted fs, kill it to speed up tests. umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) failed, try 2 ... The message keeps repeating ... Mimi > --- > testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > index 19f00532b1..054ab28611 100644 > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > @@ -313,7 +313,7 @@ ima_cleanup() > [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER > > for dir in $UMOUNT; do > - umount $dir > + tst_umount $dir > done > > if [ "$IMA_POLICY_LOADED" = 1 ]; then -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] ima_setup.sh: Use tst_umount() 2026-08-14 1:18 ` [LTP] " Mimi Zohar @ 2026-08-14 6:01 ` Petr Vorel -1 siblings, 0 replies; 11+ messages in thread From: Petr Vorel @ 2026-08-14 6:01 UTC (permalink / raw) To: Mimi Zohar; +Cc: ltp, linux-integrity Hi Mimi, > Hi Petr, > On Thu, 2026-08-13 at 13:25 +0200, Petr Vorel wrote: > > Use standard test mechanism to detect problems during umount() caused by > > GNOME's gvfsd-trash daemon. Although it will not solve the problem it at > > least warn tester. > > Reported-by: Mimi Zohar <zohar@linux.ibm.com> > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > With this patch applied and after removing everything other than ima_violations > from /opt/ltp/runtest/ima, I'm still seeing: > ima_violations 1 TINFO: $TMPDIR is on tmpfs => run on loop device > ima_violations 1 TINFO: booted with IMA policy: tcb > ima_violations 1 TINFO: using log /var/log/audit/audit.log > ima_violations 1 TINFO: verify open writers violation > ima_violations 1 TPASS: 1 open_writers violation(s) added > ima_violations 2 TINFO: verify ToMToU violation > ima_violations 2 TPASS: 1 ToMToU violation(s) added > ima_violations 3 TINFO: verify open_writers using mmapped files > tst_kconfig.c:90: TINFO: Parsing kernel config '/lib/modules/7.1.5- > 101.fc43.x86_64/build/.config' > ima_violations 3 TBROK: tst_checkpoint wait 10000 0 failed > umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. > ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) > failed, try 1 ... > ima_violations 3 TINFO: Likely gvfsd-trash is probing newly mounted fs, kill it > to speed up tests. > umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. > ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) > failed, try 2 ... I wonder if the process on your machine is gvfsd-trash or something else. Unfortunately what we can do is probably just an advice to user, killing any userspace process is probably too aggressive. So the current isn't really a workaround just kind of a hint. > The message keeps repeating ... Yeah, I wonder if trying 50x makes even sense, IMHO 5x would be enough. FYI the current code in tst_test.sh: tst_umount() { local mntpoint="${1:-$TST_MNTPOINT}" local i=0 [ -z "$mntpoint" ] && return if ! echo "$mntpoint" | grep -q ^/; then tst_brk TCONF "The '$mntpoint' is not an absolute path" fi if ! grep -q "${mntpoint%/}" /proc/mounts; then tst_res TINFO "The '$mntpoint' is not mounted, skipping umount" return fi while [ "$i" -lt 50 ]; do if umount "$mntpoint" > /dev/null; then return fi i=$((i+1)) tst_res TINFO "umount($mntpoint) failed, try $i ..." tst_res TINFO "Likely gvfsd-trash is probing newly mounted "\ "fs, kill it to speed up tests." tst_sleep 100ms done tst_res TWARN "Failed to umount($mntpoint) after 50 retries" } Kind regards, Petr > Mimi > > --- > > testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > index 19f00532b1..054ab28611 100644 > > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > @@ -313,7 +313,7 @@ ima_cleanup() > > [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER > > for dir in $UMOUNT; do > > - umount $dir > > + tst_umount $dir > > done > > if [ "$IMA_POLICY_LOADED" = 1 ]; then ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount() @ 2026-08-14 6:01 ` Petr Vorel 0 siblings, 0 replies; 11+ messages in thread From: Petr Vorel @ 2026-08-14 6:01 UTC (permalink / raw) To: Mimi Zohar; +Cc: linux-integrity, ltp Hi Mimi, > Hi Petr, > On Thu, 2026-08-13 at 13:25 +0200, Petr Vorel wrote: > > Use standard test mechanism to detect problems during umount() caused by > > GNOME's gvfsd-trash daemon. Although it will not solve the problem it at > > least warn tester. > > Reported-by: Mimi Zohar <zohar@linux.ibm.com> > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > With this patch applied and after removing everything other than ima_violations > from /opt/ltp/runtest/ima, I'm still seeing: > ima_violations 1 TINFO: $TMPDIR is on tmpfs => run on loop device > ima_violations 1 TINFO: booted with IMA policy: tcb > ima_violations 1 TINFO: using log /var/log/audit/audit.log > ima_violations 1 TINFO: verify open writers violation > ima_violations 1 TPASS: 1 open_writers violation(s) added > ima_violations 2 TINFO: verify ToMToU violation > ima_violations 2 TPASS: 1 ToMToU violation(s) added > ima_violations 3 TINFO: verify open_writers using mmapped files > tst_kconfig.c:90: TINFO: Parsing kernel config '/lib/modules/7.1.5- > 101.fc43.x86_64/build/.config' > ima_violations 3 TBROK: tst_checkpoint wait 10000 0 failed > umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. > ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) > failed, try 1 ... > ima_violations 3 TINFO: Likely gvfsd-trash is probing newly mounted fs, kill it > to speed up tests. > umount: /tmp/LTP_ima_violations.1OEcI81NHB/mntpoint: target is busy. > ima_violations 3 TINFO: umount(/tmp/LTP_ima_violations.1OEcI81NHB/mntpoint) > failed, try 2 ... I wonder if the process on your machine is gvfsd-trash or something else. Unfortunately what we can do is probably just an advice to user, killing any userspace process is probably too aggressive. So the current isn't really a workaround just kind of a hint. > The message keeps repeating ... Yeah, I wonder if trying 50x makes even sense, IMHO 5x would be enough. FYI the current code in tst_test.sh: tst_umount() { local mntpoint="${1:-$TST_MNTPOINT}" local i=0 [ -z "$mntpoint" ] && return if ! echo "$mntpoint" | grep -q ^/; then tst_brk TCONF "The '$mntpoint' is not an absolute path" fi if ! grep -q "${mntpoint%/}" /proc/mounts; then tst_res TINFO "The '$mntpoint' is not mounted, skipping umount" return fi while [ "$i" -lt 50 ]; do if umount "$mntpoint" > /dev/null; then return fi i=$((i+1)) tst_res TINFO "umount($mntpoint) failed, try $i ..." tst_res TINFO "Likely gvfsd-trash is probing newly mounted "\ "fs, kill it to speed up tests." tst_sleep 100ms done tst_res TWARN "Failed to umount($mntpoint) after 50 retries" } Kind regards, Petr > Mimi > > --- > > testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > index 19f00532b1..054ab28611 100644 > > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > @@ -313,7 +313,7 @@ ima_cleanup() > > [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER > > for dir in $UMOUNT; do > > - umount $dir > > + tst_umount $dir > > done > > if [ "$IMA_POLICY_LOADED" = 1 ]; then -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount() 2026-08-14 6:01 ` [LTP] " Petr Vorel @ 2026-09-22 17:22 ` Petr Vorel -1 siblings, 0 replies; 11+ messages in thread From: Petr Vorel @ 2026-09-22 17:22 UTC (permalink / raw) To: Mimi Zohar, linux-integrity, ltp; +Cc: Cyril Hrubis Hi Mimi, FYI I dared to merge following old proposal as https://github.com/linux-test-project/ltp/commit/fc4c633f627121564e61c7cb3412976946c71562 to follow the approach used in other LTP tests (FYI we use the same approach also for C based tests, see lib/tst_device.c). We can further improve the function if needed (reduce number of loops or suggest another daemon). Or finally remove it if it's really not needed. Kind regards, Petr > > > --- > > > testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > > index 19f00532b1..054ab28611 100644 > > > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > > @@ -313,7 +313,7 @@ ima_cleanup() > > > [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER > > > for dir in $UMOUNT; do > > > - umount $dir > > > + tst_umount $dir > > > done > > > if [ "$IMA_POLICY_LOADED" = 1 ]; then ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount() @ 2026-09-22 17:22 ` Petr Vorel 0 siblings, 0 replies; 11+ messages in thread From: Petr Vorel @ 2026-09-22 17:22 UTC (permalink / raw) To: Mimi Zohar, linux-integrity, ltp Hi Mimi, FYI I dared to merge following old proposal as https://github.com/linux-test-project/ltp/commit/fc4c633f627121564e61c7cb3412976946c71562 to follow the approach used in other LTP tests (FYI we use the same approach also for C based tests, see lib/tst_device.c). We can further improve the function if needed (reduce number of loops or suggest another daemon). Or finally remove it if it's really not needed. Kind regards, Petr > > > --- > > > testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > > index 19f00532b1..054ab28611 100644 > > > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh > > > @@ -313,7 +313,7 @@ ima_cleanup() > > > [ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER > > > for dir in $UMOUNT; do > > > - umount $dir > > > + tst_umount $dir > > > done > > > if [ "$IMA_POLICY_LOADED" = 1 ]; then -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-09-22 17:22 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-08-13 11:25 [PATCH 1/1] ima_setup.sh: Use tst_umount() Petr Vorel 2026-08-13 11:25 ` [LTP] " Petr Vorel 2026-08-13 11:48 ` [LTP] " linuxtestproject.agent 2026-08-13 11:54 ` [LTP] [PATCH 1/1] " Andrea Cervesato 2026-08-13 11:54 ` Andrea Cervesato via ltp 2026-08-14 1:18 ` Mimi Zohar 2026-08-14 1:18 ` [LTP] " Mimi Zohar 2026-08-14 6:01 ` Petr Vorel 2026-08-14 6:01 ` [LTP] " Petr Vorel 2026-09-22 17:22 ` Petr Vorel 2026-09-22 17:22 ` Petr Vorel
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.