All of lore.kernel.org
 help / color / mirror / Atom feed
From: fangyu.yu@linux.alibaba.com
To: andrew.jones@oss.qualcomm.com
Cc: fangyu.yu@linux.alibaba.com, iommu@lists.linux.dev, jgg@ziepe.ca,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	oro@8bytes.org, palmer@dabbelt.com, pjw@kernel.org,
	robin.murphy@arm.com, tomasz.jeznach@linux.dev, will@kernel.org
Subject: Re: [PATCH] iommu/generic_pt: Fix the RISC-V supported feature mask
Date: Tue, 18 Aug 2026 20:29:02 +0800	[thread overview]
Message-ID: <20260818122902.35665-1-fangyu.yu@linux.alibaba.com> (raw)
In-Reply-To: <20260818092444.42755-1-andrew.jones@oss.qualcomm.com>

>The RISC-V format advertises Svpbmt to its users, but omits the feature
>from PT_SUPPORTED_FEATURES. Add it there so configurations which enable
>Svpbmt pass generic page-table feature validation.
>
>Fixes: f196a8668797 ("iommu/riscv: Advertise Svpbmt support to generic page table")
>Signed-off-by: Andrew Jones <andrew.jones@oss.qualcomm.com>
>---
> drivers/iommu/generic_pt/fmt/iommu_riscv64.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/iommu/generic_pt/fmt/iommu_riscv64.c b/drivers/iommu/generic_pt/fmt/iommu_riscv64.c
>index b18fc4d109f5..1bb74114fb02 100644
>--- a/drivers/iommu/generic_pt/fmt/iommu_riscv64.c
>+++ b/drivers/iommu/generic_pt/fmt/iommu_riscv64.c
>@@ -7,7 +7,8 @@
> #define PT_SUPPORTED_FEATURES                                  \
> 	(BIT(PT_FEAT_SIGN_EXTEND) | BIT(PT_FEAT_FLUSH_RANGE) | \
> 	 BIT(PT_FEAT_RISCV_SVNAPOT_64K) |                      \
>-	 BIT(PT_FEAT_DETAILED_GATHER))
>+	 BIT(PT_FEAT_DETAILED_GATHER) |                        \
>+	 BIT(PT_FEAT_RISCV_SVPBMT))
> #define PT_FORCE_ENABLED_FEATURES BIT(PT_FEAT_DETAILED_GATHER)
> 
> #include "iommu_template.h"
>-- 
>2.43.0
>

Thanks for fixing this.

When I originally tested the Svpbmt support, I had CONFIG_DEBUG_GENERIC_PT
enabled by default, so this issue was hidden by the debug supported-feature
mask and did not show up in my testing.

Tested-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>

WARNING: multiple messages have this Message-ID (diff)
From: fangyu.yu@linux.alibaba.com
To: andrew.jones@oss.qualcomm.com
Cc: fangyu.yu@linux.alibaba.com, iommu@lists.linux.dev, jgg@ziepe.ca,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	oro@8bytes.org, palmer@dabbelt.com, pjw@kernel.org,
	robin.murphy@arm.com, tomasz.jeznach@linux.dev, will@kernel.org
Subject: Re: [PATCH] iommu/generic_pt: Fix the RISC-V supported feature mask
Date: Tue, 18 Aug 2026 20:29:02 +0800	[thread overview]
Message-ID: <20260818122902.35665-1-fangyu.yu@linux.alibaba.com> (raw)
In-Reply-To: <20260818092444.42755-1-andrew.jones@oss.qualcomm.com>

>The RISC-V format advertises Svpbmt to its users, but omits the feature
>from PT_SUPPORTED_FEATURES. Add it there so configurations which enable
>Svpbmt pass generic page-table feature validation.
>
>Fixes: f196a8668797 ("iommu/riscv: Advertise Svpbmt support to generic page table")
>Signed-off-by: Andrew Jones <andrew.jones@oss.qualcomm.com>
>---
> drivers/iommu/generic_pt/fmt/iommu_riscv64.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/iommu/generic_pt/fmt/iommu_riscv64.c b/drivers/iommu/generic_pt/fmt/iommu_riscv64.c
>index b18fc4d109f5..1bb74114fb02 100644
>--- a/drivers/iommu/generic_pt/fmt/iommu_riscv64.c
>+++ b/drivers/iommu/generic_pt/fmt/iommu_riscv64.c
>@@ -7,7 +7,8 @@
> #define PT_SUPPORTED_FEATURES                                  \
> 	(BIT(PT_FEAT_SIGN_EXTEND) | BIT(PT_FEAT_FLUSH_RANGE) | \
> 	 BIT(PT_FEAT_RISCV_SVNAPOT_64K) |                      \
>-	 BIT(PT_FEAT_DETAILED_GATHER))
>+	 BIT(PT_FEAT_DETAILED_GATHER) |                        \
>+	 BIT(PT_FEAT_RISCV_SVPBMT))
> #define PT_FORCE_ENABLED_FEATURES BIT(PT_FEAT_DETAILED_GATHER)
> 
> #include "iommu_template.h"
>-- 
>2.43.0
>

Thanks for fixing this.

When I originally tested the Svpbmt support, I had CONFIG_DEBUG_GENERIC_PT
enabled by default, so this issue was hidden by the debug supported-feature
mask and did not show up in my testing.

Tested-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-08-18 12:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  9:24 [PATCH] iommu/generic_pt: Fix the RISC-V supported feature mask Andrew Jones
2026-08-18  9:24 ` Andrew Jones
2026-08-18 12:29 ` fangyu.yu [this message]
2026-08-18 12:29   ` fangyu.yu
2026-08-18 13:14 ` Jason Gunthorpe
2026-08-18 13:14   ` Jason Gunthorpe
2026-08-19  3:55 ` Nutty.Liu
2026-08-19  3:55   ` Nutty.Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818122902.35665-1-fangyu.yu@linux.alibaba.com \
    --to=fangyu.yu@linux.alibaba.com \
    --cc=andrew.jones@oss.qualcomm.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=oro@8bytes.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tomasz.jeznach@linux.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.