Re: [PATCH v2 0/4] crypto: rockchip: Add RK356x/RK3588 cryptographic offloader

From: Eric Biggers <ebiggers@kernel.org>
To: Diederik de Haas <diederik@cknow-tech.com>
Cc: Dawid Olesinski <dawidro@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Corentin Labbe <clabbe@baylibre.com>,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] crypto: rockchip: Add RK356x/RK3588 cryptographic offloader
Date: Tue, 18 Aug 2026 11:58:10 -0700	[thread overview]
Message-ID: <20260818185810.GA7030@quark> (raw)
In-Reply-To: <DKF8V3IHKTL2.1PUA8O5IVIRYC@cknow-tech.com>

On Mon, Aug 03, 2026 at 12:42:03PM +0200, Diederik de Haas wrote:
> crypto-rk3566-test-no-crypto-module-log.txt:
> https://paste.sr.ht/~diederik/bb5dbfd59f244a6422b965b30f9796ebbfdb1fcb
> crypto-rk3566-test-with-crypto-module-log.txt:
> https://paste.sr.ht/~diederik/ea72297678e19cbbc987de9548f9884382e1d1cc
> crypto-rk3568-test-no-crypto-module-log.txt:
> https://paste.sr.ht/~diederik/309e519e6b1c31f4c1c5bcb1ea16cc8569a54830
> crypto-rk3568-test-with-crypto-module-log.txt:
> https://paste.sr.ht/~diederik/1e1e938ebbbae75128974fe0a7c240843bce04c8
> crypto-rk3588-test-no-crypto-module-log.txt:
> https://paste.sr.ht/~diederik/9a2adc2b2e42131445ce4576589e00ecf51ccb4b
> crypto-rk3588-test-with-crypto-module-log.txt:
> https://paste.sr.ht/~diederik/e04c11c8809031ca45662f7d4c227c1ba6162b65

Thanks for running some benchmarks!

Looking at your results for rk3566 for example, SHA-256 on 4096-byte
blocks is 115 cycles/operation for sha256-lib (i.e. ARMv8 CE) or 3027
cycles/operation for rk2-sha256.  So the Rockchip driver is 26 times
slower than simply using the existing well-tested CPU-based code.

Don't you love "accelerators" that make things 26 times slower?

I guess we'll get the usual argument that this driver is really just for
"testing" or whatever.

- Eric