Re: [PATCH 1/4] arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `out-band-wakeup` property is added to the device tree but is completely ignored by the kernel because no driver or core code parses it.
--

--- Patch [1]: [PATCH 1/4] arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices ---
commit 74f82c5ded5daaf7cf6527a753badc1049e2cd79
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices

This commit adds the out-band-wakeup property to the mcu_mcan0 and
mcu_mcan1 nodes in the k3-am62-lp-sk device tree. The commit message states
this allows the out_band_wakeup flag to be enabled during suspend for m_can
devices.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> index dfd65c00f5b95..011f2f3703755 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> @@ -283,6 +283,7 @@ &gpmc0 {
>  };
>  
>  &mcu_mcan0 {
> +	out-band-wakeup;

[Severity: Medium]
Is this property parsed anywhere in the kernel?

Looking at the kernel code, there doesn't appear to be any driver or core
code that reads the out-band-wakeup property, nor does it seem to be defined
in any device tree bindings.

Without a driver (such as m_can) parsing this property and setting the flag,
the intended wakeup functionality from deep low power states will fail to
operate.

Are there missing driver changes that should accompany this device tree
modification to actually enable this feature?

>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
>  	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
> @@ -294,6 +295,7 @@ &mcu_mcan0 {
>  };
>  
>  &mcu_mcan1 {
> +	out-band-wakeup;
>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-smth-v1-0-e1738a38d58e@ti.com?part=1