All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices
Date: Thu, 20 Aug 2026 22:18:13 +0000	[thread overview]
Message-ID: <20260820221813.E00A61F00A3F@smtp.kernel.org> (raw)
In-Reply-To: <20260820-smth-v1-3-e1738a38d58e@ti.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `out-band-wakeup` property is added to the device tree but is neither parsed by any kernel C code nor documented in device tree bindings, rendering it functionally inert.
--

--- Patch [3]: [PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices ---
commit 4ca80a2e891d70e706f8bb44ea395ee00e41e9dc
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices

This commit adds the out-band-wakeup property to the mcu_mcan0 and mcu_mcan1
nodes in the k3-am62p5-sk device tree. The intent is to enable the
out_band_wakeup flag during suspend so the devices can serve as wakeup
sources from deep low-power states.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
[ ... ]
> @@ -815,6 +815,7 @@ &epwm1 {
>  };
>  
>  &mcu_mcan0 {
> +	out-band-wakeup;

[Severity: Medium]
Is this property parsed by any driver code in the kernel?

The commit message indicates this allows the out_band_wakeup flag to be
enabled during suspend, but there does not appear to be any C code that
actually parses the out-band-wakeup property from the device tree to apply
this flag.

Without driver support to parse this, the property will remain inert. Does
this rely on a separate driver patch that is missing from this series?

Additionally, is this property documented in the device tree bindings? If
not, it will trigger dtbs_check validation errors.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-smth-v1-0-e1738a38d58e@ti.com?part=3

  reply	other threads:[~2026-08-20 22:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 22:08 [PATCH 0/4] arm64: dts: ti: add out-band-wakeup property to m_can devices Kendall Willis
2026-08-20 22:08 ` [PATCH 1/4] arm64: dts: ti: k3-am62-lp-sk: " Kendall Willis
2026-08-20 22:15   ` sashiko-bot
2026-08-20 22:08 ` [PATCH 2/4] arm64: dts: ti: k3-am62a7-sk: " Kendall Willis
2026-08-20 22:17   ` sashiko-bot
2026-08-20 22:08 ` [PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: " Kendall Willis
2026-08-20 22:18   ` sashiko-bot [this message]
2026-08-20 22:08 ` [PATCH 4/4] arm64: dts: ti: k3-am62d2-evm: " Kendall Willis
2026-08-20 22:16   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260820221813.E00A61F00A3F@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=k-willis@ti.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.