From: sashiko-bot@kernel.org
To: "Johan Dahlin" <jdahlin@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 4/5] hwmon: (nct6683) Restore fan control mode on driver removal
Date: Tue, 25 Aug 2026 09:33:20 +0000 [thread overview]
Message-ID: <20260825093321.533271F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260825092546.669450-5-jdahlin@gmail.com>
> A fan switched to manual mode stays there when the driver is unloaded,
> leaving it pinned at whatever pwm value was last written with nothing left
> to update it.
>
> Record the fan control mode register during probe and put it back with a
> devres action, so the EC resumes control of the fans the driver took over
> while anything the firmware had already set is left alone. The action is
> registered before the hwmon device, so it runs after the attributes are
> gone and cannot race with a pwm write, and it is a no-op if probe fails
> before the driver touches the register.
>
> Boards where the driver does not manage the register do not register it.
>
> Signed-off-by: Johan Dahlin <jdahlin@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260825092546.669450-1-jdahlin@gmail.com?part=4
next prev parent reply other threads:[~2026-08-25 9:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 9:25 [PATCH 0/5] hwmon: (nct6683) Fan control for ASRock B850 Steel Legend WiFi Johan Dahlin
2026-08-25 9:25 ` [PATCH 1/5] hwmon: (nct6683) Retry pwm writes until they take effect Johan Dahlin
2026-08-25 9:34 ` sashiko-bot
2026-08-25 9:25 ` [PATCH 2/5] hwmon: (nct6683) Add customer ID for ASRock B850 Steel Legend WiFi Johan Dahlin
2026-08-25 9:28 ` sashiko-bot
2026-08-25 9:25 ` [PATCH 3/5] hwmon: (nct6683) Add pwm[1-8]_enable Johan Dahlin
2026-08-25 9:44 ` sashiko-bot
2026-08-28 16:17 ` Guenter Roeck
2026-08-25 9:25 ` [PATCH 4/5] hwmon: (nct6683) Restore fan control mode on driver removal Johan Dahlin
2026-08-25 9:33 ` sashiko-bot [this message]
2026-08-25 9:25 ` [PATCH 5/5] hwmon: (nct6683) Enable pwm control on ASRock B850 Steel Legend WiFi Johan Dahlin
2026-08-25 9:38 ` sashiko-bot
2026-09-17 17:35 ` Fabio Baltieri
2026-09-17 20:03 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825093321.533271F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jdahlin@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.