Re: [PATCH 1/5] hwmon: (nct6683) Retry pwm writes until they take effect

[sashiko-bot@kernel.org]

> store_pwm() waits a fixed 1-2 ms for the EC to hand over the fan
> configuration registers before writing. That delay dates back to
> commit 91918d13eb17 ("hwmon: (nct6683) Add basic support for NCT6683 on
> Mitac boards") and, pwm being read-only elsewhere, has never been
> exercised against other firmware.
> 
> It is too short for at least one of them: on an ASRock B850 Steel Legend
> WiFi (NCT6686D), two of six consecutive pwm writes were silently discarded,
> leaving the fan on its previous setting.
> 
> Read the value back and repeat the sequence when it did not stick, waiting
> longer each time and reporting -EIO if it never does. Raising the delay for
> everyone would penalise boards that work today, while a write that succeeds
> first time issues the same register sequence as before.
> 
> Signed-off-by: Johan Dahlin <jdahlin@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825092546.669450-1-jdahlin@gmail.com?part=1