From: sashiko-bot@kernel.org
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: conor+dt@kernel.org, olteanv@gmail.com,
linux-clk@vger.kernel.org, lee@kernel.org,
linux-phy@lists.infradead.org, vkoul@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, neil.armstrong@linaro.org,
mfd@lists.linux.dev
Subject: Re: [PATCH v11 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller
Date: Tue, 25 Aug 2026 21:27:40 +0000 [thread overview]
Message-ID: <20260825212740.D06571F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260826-zx29clk-v11-1-f8ad59c6426c@gmail.com>
> These SoCs have 3 clock and reset controllers: Top, Matrix and LSP.
> Clocks go from oscillator -> top -> matrix -> LSP, with a register in
> top controlling most clocks that get passed to matrix and a register in
> matrix controlling all the clocks that get passed to LSP.
>
> Generally every device has two clocks (one work clock, and one that
> connects it to the bus, I call it PCLK), two reset bits (I don't know
> what the difference is - sometimes asserting one is enough to reset the
> device, sometimes both need to be asserted). PCLK and WCLK are
> controlled by individual gates. Some devices have a mux and/or a
> divider for their work clock. Some devices, like the GPIO controller,
> only have reset bits and no clocks.
>
> The top clock controller is fed by a 26 MHz external oscillator and has 4
> PLLs to generate other clock rates. ZTE's kernel mostly relies on the
> [ ... ]
> likely that a handful more clocks will be added in the future, but not a
> large number.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Stefan Dösinger <stefandoesinger@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-zx29clk-v11-0-f8ad59c6426c@gmail.com?part=1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: conor+dt@kernel.org, olteanv@gmail.com,
linux-clk@vger.kernel.org, lee@kernel.org,
linux-phy@lists.infradead.org, vkoul@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, neil.armstrong@linaro.org,
mfd@lists.linux.dev
Subject: Re: [PATCH v11 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller
Date: Tue, 25 Aug 2026 21:27:40 +0000 [thread overview]
Message-ID: <20260825212740.D06571F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260826-zx29clk-v11-1-f8ad59c6426c@gmail.com>
> These SoCs have 3 clock and reset controllers: Top, Matrix and LSP.
> Clocks go from oscillator -> top -> matrix -> LSP, with a register in
> top controlling most clocks that get passed to matrix and a register in
> matrix controlling all the clocks that get passed to LSP.
>
> Generally every device has two clocks (one work clock, and one that
> connects it to the bus, I call it PCLK), two reset bits (I don't know
> what the difference is - sometimes asserting one is enough to reset the
> device, sometimes both need to be asserted). PCLK and WCLK are
> controlled by individual gates. Some devices have a mux and/or a
> divider for their work clock. Some devices, like the GPIO controller,
> only have reset bits and no clocks.
>
> The top clock controller is fed by a 26 MHz external oscillator and has 4
> PLLs to generate other clock rates. ZTE's kernel mostly relies on the
> [ ... ]
> likely that a handful more clocks will be added in the future, but not a
> large number.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Stefan Dösinger <stefandoesinger@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-zx29clk-v11-0-f8ad59c6426c@gmail.com?part=1
next prev parent reply other threads:[~2026-08-25 21:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 21:23 [PATCH v11 00/12] ZTE zx297520v3 clock bindings and driver Stefan Dösinger
2026-08-25 21:23 ` Stefan Dösinger
2026-08-25 21:24 ` [PATCH v11 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:27 ` sashiko-bot [this message]
2026-08-25 21:27 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 02/12] dt-bindings: clk: zte: Add zx297520v3 matrix " Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:29 ` sashiko-bot
2026-08-25 21:29 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 03/12] dt-bindings: clk: zte: Add zx297520v3 LSP " Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:28 ` sashiko-bot
2026-08-25 21:28 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 04/12] ARM: dts: zte: Declare zx297520v3 CRM device nodes Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:31 ` sashiko-bot
2026-08-25 21:31 ` sashiko-bot
2026-09-02 10:29 ` Stefan Dösinger
2026-09-02 10:29 ` Stefan Dösinger
2026-09-08 18:22 ` Krzysztof Kozlowski
2026-09-08 18:22 ` Krzysztof Kozlowski
2026-08-25 21:24 ` [PATCH v11 05/12] mfd: zx297520v3: Add a clock and reset MFD driver Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:31 ` sashiko-bot
2026-08-25 21:31 ` sashiko-bot
2026-09-10 16:17 ` Lee Jones
2026-09-10 16:17 ` Lee Jones
2026-09-10 19:14 ` Stefan Dösinger
2026-09-10 19:14 ` Stefan Dösinger
2026-08-25 21:24 ` [PATCH v11 06/12] clk: zte: Add Clock registration infrastructure Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:32 ` sashiko-bot
2026-08-25 21:32 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 07/12] clk: zte: Add regmap-based clocks Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:38 ` sashiko-bot
2026-08-25 21:38 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 08/12] clk: zte: Add zx PLL support infrastructure Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:35 ` sashiko-bot
2026-08-25 21:35 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 09/12] clk: zte: Introduce a driver for zx297520v3 top clocks Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:38 ` sashiko-bot
2026-08-25 21:38 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 10/12] clk: zte: Introduce a driver for zx297520v3 matrix clocks Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:36 ` sashiko-bot
2026-08-25 21:36 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 11/12] clk: zte: Introduce a driver for zx297520v3 LSP clocks Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:34 ` sashiko-bot
2026-08-25 21:34 ` sashiko-bot
2026-08-25 21:24 ` [PATCH v11 12/12] reset: zte: Add a zx297520v3 reset driver Stefan Dösinger
2026-08-25 21:24 ` Stefan Dösinger
2026-08-25 21:35 ` sashiko-bot
2026-08-25 21:35 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825212740.D06571F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mfd@lists.linux.dev \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefandoesinger@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.