From: Kane Chen <kane_chen@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Troy Lee <troy_lee@aspeedtech.com>, Kane Chen <kane_chen@aspeedtech.com>
Subject: [PATCH v1 0/2] hw/misc/aspeed_sbc: Fix ABR and secure boot state reporting
Date: Mon, 31 Aug 2026 05:36:59 +0000 [thread overview]
Message-ID: <20260831053658.462203-1-kane_chen@aspeedtech.com> (raw)
The ASPEED Secure Boot Controller (SBC) model currently derives its
eMMC ABR (Alternate Boot Recovery) and secure boot enable bits from
fixed "emmc-abr"/"signing-settings" machine properties. The logic
that reflects these properties into R_STATUS is broken, so neither
bit can ever actually be reported as enabled, and for secure boot
this also leaves R_STATUS and R_QSR inconsistent with each other.
This series replaces both properties with logic that derives the ABR
and secure boot state directly from the relevant OTP configuration
straps, matching how the real hardware determines these settings.
Any feedback or suggestions are appreciated!
Kane-Chen-AS (2):
hw/misc/aspeed_sbc: Derive ABR state from OTP config straps
hw/misc/aspeed_sbc: Derive secure boot state from OTP config straps
include/hw/misc/aspeed_sbc.h | 3 --
hw/misc/aspeed_sbc.c | 69 +++++++++++++++++++++++++++++-------
2 files changed, 56 insertions(+), 16 deletions(-)
--
2.43.0
next reply other threads:[~2026-08-31 5:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 5:36 Kane Chen [this message]
2026-08-31 5:37 ` [PATCH v1 1/2] hw/misc/aspeed_sbc: Derive ABR state from OTP config straps Kane Chen
2026-08-31 5:40 ` Jamin Lin
2026-08-31 11:10 ` Cédric Le Goater
2026-09-01 9:25 ` Kane Chen
2026-09-03 7:22 ` Cédric Le Goater
2026-09-03 7:35 ` Kane Chen
2026-08-31 5:37 ` [PATCH v1 2/2] hw/misc/aspeed_sbc: Derive secure boot " Kane Chen
2026-08-31 5:41 ` Jamin Lin
2026-08-31 11:14 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831053658.462203-1-kane_chen@aspeedtech.com \
--to=kane_chen@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.