Re: [PATCH v1 1/4] dt-bindings: Add CIX Sky1 USB bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Custom devicetree properties do not follow standard naming conventions (missing vendor prefix and using underscores).
- [Low] The unit-address in the example node name does not match the first address in its 'reg' property.
--

commit a013b6f9b48698942425d14e2f091ce0c4c04f8c
Author: Hongliang Yang <hongliang.yang@cixtech.com>

dt-bindings: Add CIX Sky1 USB bindings

This commit adds device tree bindings for the CIX Sky1 USB3 PHY and
Cadence USBSSP controller glue layer.

> diff --git a/Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml b/Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml
> new file mode 100644
> index 0000000000000..47202ff5b9e57
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml

[ ... ]

> @@ -0,0 +1,153 @@
> +  reset-names:
> +    items:
> +      - const: usb_preset
> +      - const: usb_reset
> +
> +  cix,usb_syscon:

[Severity: Low]
Does this property name follow the standard devicetree naming conventions?
Standard convention strongly prefers hyphens over underscores in property
names (e.g., cix,usb-syscon).

> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the Sky1 S5 system controller used to program USB mode
> +      strap controls.
> +
> +  axi_bmax_value:

[Severity: Low]
Does this property need a vendor prefix and hyphens instead of underscores?
Custom hardware-specific properties require a vendor prefix to avoid
collisions with standard properties (e.g., cix,axi-bmax-value).

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0x7
> +    description:
> +      AXI bus maximum burst length configuration value.

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/cix,sky1.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/reset/cix,sky1-s5-system-control.h>
> +
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        usb@91c0300 {

[Severity: Low]
Does the unit address 91c0300 match the first address in the reg property?
The Devicetree Specification requires that the unit address in a node name
exactly matches the first address specified in the node's reg property.
Here, it does not match the actual base register address 091c0314, which
will trigger a simple_bus_reg warning when the devicetree compiler evaluates
the example.

> +            compatible = "cix,sky1-usbssp";
> +            #address-cells = <2>;
> +            #size-cells = <2>;
> +            ranges;
> +
> +            reg = <0x00 0x091c0314 0x00 0x4>,
> +                  <0x00 0x091c0400 0x00 0x4>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831082309.3854507-1-hongliang.yang@cixtech.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy