All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongliang Yang <hongliang.yang@cixtech.com>
Cc: cix-kernel-upstream@cixtech.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, fugang.duan@cixtech.com,
	gregkh@linuxfoundation.org, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-usb@vger.kernel.org, neil.armstrong@linaro.org,
	p.zabel@pengutronix.de, pawell@cadence.com,
	peter.chen@kernel.org, robh@kernel.org, rogerq@kernel.org,
	vkoul@kernel.org
Subject: Re: [PATCH v3 0/5] Add CIX Sky1 USB3/USBSSP support
Date: Thu, 3 Sep 2026 08:29:28 +0200	[thread overview]
Message-ID: <6ca4ba08-2313-4890-9a88-259799189d52@kernel.org> (raw)
In-Reply-To: <20260903023521.2064986-1-hongliang.yang@cixtech.com>

On 03/09/2026 04:35, Hongliang Yang wrote:
> Add USB3 PHY binding and driver, Cadence USBSSP glue binding and
> driver, and USB4/USB5 device tree nodes for the CIX Sky1 SoC.
> 
> This series adds support for the USB4 and USB5 controllers (based on
> Cadence USBSSP DRD) found on the CIX Sky1 SoC, along with their
> associated multi-port USB3 PHY.
> 
> The two wrapper nodes each carry two 4-byte register windows: these
> are per-controller RCSU control/status registers (AXI cache attribute
> and clock-status) that live inside the shared RCSU aperture, so they
> cannot be expressed as a syscon; the OTG mode straps live in the S5
> system control block and are referenced through the cix,usb-syscon
> phandle.  This was discussed during review of v1 [1].
> 
> Changes in v3:
> 

I do not see how you addressed my feedback from v1. I asked, not to
combine USB patches with other subsystems, within one patchset. These
are separate patchsets.

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongliang Yang <hongliang.yang@cixtech.com>
Cc: cix-kernel-upstream@cixtech.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, fugang.duan@cixtech.com,
	gregkh@linuxfoundation.org, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-usb@vger.kernel.org, neil.armstrong@linaro.org,
	p.zabel@pengutronix.de, pawell@cadence.com,
	peter.chen@kernel.org, robh@kernel.org, rogerq@kernel.org,
	vkoul@kernel.org
Subject: Re: [PATCH v3 0/5] Add CIX Sky1 USB3/USBSSP support
Date: Thu, 3 Sep 2026 08:29:28 +0200	[thread overview]
Message-ID: <6ca4ba08-2313-4890-9a88-259799189d52@kernel.org> (raw)
In-Reply-To: <20260903023521.2064986-1-hongliang.yang@cixtech.com>

On 03/09/2026 04:35, Hongliang Yang wrote:
> Add USB3 PHY binding and driver, Cadence USBSSP glue binding and
> driver, and USB4/USB5 device tree nodes for the CIX Sky1 SoC.
> 
> This series adds support for the USB4 and USB5 controllers (based on
> Cadence USBSSP DRD) found on the CIX Sky1 SoC, along with their
> associated multi-port USB3 PHY.
> 
> The two wrapper nodes each carry two 4-byte register windows: these
> are per-controller RCSU control/status registers (AXI cache attribute
> and clock-status) that live inside the shared RCSU aperture, so they
> cannot be expressed as a syscon; the OTG mode straps live in the S5
> system control block and are referenced through the cix,usb-syscon
> phandle.  This was discussed during review of v1 [1].
> 
> Changes in v3:
> 

I do not see how you addressed my feedback from v1. I asked, not to
combine USB patches with other subsystems, within one patchset. These
are separate patchsets.

Best regards,
Krzysztof

  parent reply	other threads:[~2026-09-03  6:29 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  8:23 [PATCH v1 0/4] Add CIX Sky1 USB3/USBSSP support Hongliang Yang
2026-08-31  8:23 ` Hongliang Yang
2026-08-31  8:23 ` [PATCH v1 1/4] dt-bindings: Add CIX Sky1 USB bindings Hongliang Yang
2026-08-31  8:23   ` Hongliang Yang
2026-08-31  8:32   ` sashiko-bot
2026-08-31  8:32     ` sashiko-bot
2026-08-31 16:07   ` Conor Dooley
2026-08-31 16:07     ` Conor Dooley
2026-09-01  5:47   ` Krzysztof Kozlowski
2026-09-01  5:47     ` Krzysztof Kozlowski
2026-09-02  3:23     ` Hongliang Yang
2026-09-02  3:23       ` Hongliang Yang
2026-09-03  6:28       ` Krzysztof Kozlowski
2026-09-03  6:28         ` Krzysztof Kozlowski
2026-09-03  2:35     ` [PATCH v3 0/5] Add CIX Sky1 USB3/USBSSP support Hongliang Yang
2026-09-03  2:35       ` Hongliang Yang
2026-09-03  2:35       ` [PATCH v3 1/5] dt-bindings: phy: Add CIX Sky1 USB3 PHY Hongliang Yang
2026-09-03  2:35         ` Hongliang Yang
2026-09-03  2:35       ` [PATCH v3 2/5] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
2026-09-03  2:35         ` Hongliang Yang
2026-09-03  6:30         ` Krzysztof Kozlowski
2026-09-03  6:30           ` Krzysztof Kozlowski
2026-09-03  2:35       ` [PATCH v3 3/5] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang
2026-09-03  2:35         ` Hongliang Yang
2026-09-03  2:48         ` sashiko-bot
2026-09-03  2:48           ` sashiko-bot
2026-09-03  2:35       ` [PATCH v3 4/5] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-09-03  2:35         ` Hongliang Yang
2026-09-03  2:45         ` sashiko-bot
2026-09-03  2:45           ` sashiko-bot
2026-09-03  2:35       ` [PATCH v3 5/5] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
2026-09-03  2:35         ` Hongliang Yang
2026-09-03  6:29       ` Krzysztof Kozlowski [this message]
2026-09-03  6:29         ` [PATCH v3 0/5] Add CIX Sky1 USB3/USBSSP support Krzysztof Kozlowski
2026-08-31  8:23 ` [PATCH v1 2/4] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang
2026-08-31  8:23   ` Hongliang Yang
2026-08-31  8:33   ` sashiko-bot
2026-08-31  8:33     ` sashiko-bot
2026-08-31  8:23 ` [PATCH v1 3/4] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-08-31  8:23   ` Hongliang Yang
2026-08-31  8:41   ` sashiko-bot
2026-08-31  8:41     ` sashiko-bot
2026-08-31  8:57   ` Philipp Zabel
2026-08-31  8:57     ` Philipp Zabel
2026-08-31  8:23 ` [PATCH v1 4/4] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
2026-08-31  8:23   ` Hongliang Yang
2026-08-31  8:33   ` sashiko-bot
2026-08-31  8:33     ` sashiko-bot
2026-09-02  3:21 ` [PATCH v2 0/5] Add CIX Sky1 USB3/USBSSP support Hongliang Yang
2026-09-02  3:21   ` Hongliang Yang
2026-09-02  3:21 ` [PATCH v2 1/5] dt-bindings: phy: Add CIX Sky1 USB3 PHY Hongliang Yang
2026-09-02  3:21   ` Hongliang Yang
2026-09-02  3:21 ` [PATCH v2 2/5] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
2026-09-02  3:21   ` Hongliang Yang
2026-09-02  3:21 ` [PATCH v2 3/5] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang
2026-09-02  3:21   ` Hongliang Yang
2026-09-02  3:32   ` sashiko-bot
2026-09-02  3:32     ` sashiko-bot
2026-09-02  3:21 ` [PATCH v2 4/5] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-09-02  3:21   ` Hongliang Yang
2026-09-02  3:32   ` sashiko-bot
2026-09-02  3:32     ` sashiko-bot
2026-09-02  3:21 ` [PATCH v2 5/5] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
2026-09-02  3:21   ` Hongliang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ca4ba08-2313-4890-9a88-259799189d52@kernel.org \
    --to=krzk@kernel.org \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fugang.duan@cixtech.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hongliang.yang@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pawell@cadence.com \
    --cc=peter.chen@kernel.org \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.