All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanna Czenczek <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
	"Denis V . Lunev" <den@openvz.org>,
	Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH 8/9] block/accounting: Move latency_ns override down
Date: Mon, 31 Aug 2026 15:52:04 +0200	[thread overview]
Message-ID: <20260831135206.126184-9-hreitz@redhat.com> (raw)
In-Reply-To: <20260831135206.126184-1-hreitz@redhat.com>

I am not quite sure why `latency_ns` is overridden by a fixed value in
qtest mode because personally, I find it much better if I can
individually change requests' latency by modifying the qtest clock.

But I'm not going to change existing behavior for the histogram and
such, so I will just move this override after the latency has been
evaluated regarding a potential BLOCK_IO_DELAY event.

Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
---
 block/accounting.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/block/accounting.c b/block/accounting.c
index debf1924455..223becd2e04 100644
--- a/block/accounting.c
+++ b/block/accounting.c
@@ -271,10 +271,6 @@ static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie *cookie,
     int64_t time_ns = qemu_clock_get_ns(clock_type);
     int64_t latency_ns = time_ns - cookie->start_time_ns;
 
-    if (qtest_enabled()) {
-        latency_ns = qtest_latency_ns;
-    }
-
     assert(cookie->type < BLOCK_MAX_IOTYPE);
 
     if (cookie->type == BLOCK_ACCT_NONE) {
@@ -292,6 +288,10 @@ static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie *cookie,
                                        cookie->bytes);
     }
 
+    if (qtest_enabled()) {
+        latency_ns = qtest_latency_ns;
+    }
+
     WITH_QEMU_LOCK_GUARD(&stats->lock) {
         if (failed) {
             stats->failed_ops[cookie->type]++;
-- 
2.55.0



  parent reply	other threads:[~2026-08-31 13:53 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 13:51 [PATCH 0/9] block: BLOCK_IO_DELAY event Hanna Czenczek
2026-08-31 13:51 ` [PATCH 1/9] block/accounting: Add offset to BlockAcctCookie Hanna Czenczek
2026-09-07 10:05   ` Jesper Wendel Devantier
2026-08-31 13:51 ` [PATCH 2/9] qapi/block: Add IoAccountingOperation enum Hanna Czenczek
2026-09-03 14:32   ` Markus Armbruster
2026-09-16  8:09     ` Hanna Czenczek
2026-08-31 13:51 ` [PATCH 3/9] qapi/block: Add BLOCK_IO_DELAY event Hanna Czenczek
2026-09-03 14:36   ` Markus Armbruster
2026-09-16  8:08     ` Hanna Czenczek
2026-09-16  9:57       ` Markus Armbruster
2026-08-31 13:52 ` [PATCH 4/9] block-backend: Public blk_get_attached_dev_path() Hanna Czenczek
2026-08-31 13:52 ` [PATCH 5/9] block/accounting: Add BB field to latency checker Hanna Czenczek
2026-09-22 12:14   ` Kevin Wolf
2026-09-23 11:05     ` Hanna Czenczek
2026-08-31 13:52 ` [PATCH 6/9] block/accounting: Emit BLOCK_IO_DELAY event Hanna Czenczek
2026-09-03 14:23   ` Stefan Hajnoczi
2026-09-16  8:14     ` Hanna Czenczek
2026-09-16 12:04       ` Hanna Czenczek
2026-09-21 20:48         ` Stefan Hajnoczi
2026-09-23 10:45           ` Hanna Czenczek
2026-09-22 12:44   ` Kevin Wolf
2026-09-23 11:11     ` Hanna Czenczek
2026-08-31 13:52 ` [PATCH 7/9] block: Add delay-alert-ms property Hanna Czenczek
2026-09-03 14:30   ` Stefan Hajnoczi
2026-09-16  8:17     ` Hanna Czenczek
2026-09-22 12:51       ` Kevin Wolf
2026-08-31 13:52 ` Hanna Czenczek [this message]
2026-09-03 15:08   ` [PATCH 8/9] block/accounting: Move latency_ns override down Stefan Hajnoczi
2026-09-16  8:21     ` Hanna Czenczek
2026-09-21 20:42       ` Stefan Hajnoczi
2026-09-22 13:03         ` Kevin Wolf
2026-09-22 13:44           ` Alberto Garcia
2026-09-22 13:52             ` Kevin Wolf
2026-09-23 10:50               ` Hanna Czenczek
2026-08-31 13:52 ` [PATCH 9/9] iotests: Add delay-alert test Hanna Czenczek
2026-09-03 15:16   ` Stefan Hajnoczi
2026-09-03 14:08 ` [PATCH 0/9] block: BLOCK_IO_DELAY event Stefan Hajnoczi
2026-09-16  8:04   ` Hanna Czenczek
2026-09-21 20:41     ` Stefan Hajnoczi
2026-09-22 13:31       ` Kevin Wolf
2026-09-22 17:18         ` Stefan Hajnoczi
2026-09-23 10:52           ` Hanna Czenczek
2026-09-24 14:51             ` Stefan Hajnoczi
2026-09-23 10:48       ` Hanna Czenczek
2026-09-23 14:50         ` Kevin Wolf
2026-09-24 15:17         ` Stefan Hajnoczi
2026-09-24 18:31           ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831135206.126184-9-hreitz@redhat.com \
    --to=hreitz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.