Re: [PATCH 2/9] qapi/block: Add IoAccountingOperation enum

[Markus Armbruster <armbru@redhat.com>]

Hanna Czenczek <hreitz@redhat.com> writes:

> This enum gives more information than IoOperationType (which is used for
> the rerror/werror distinction) to identify operation types for block
> accounting.
>
> Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
> ---
>  qapi/block.json | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/qapi/block.json b/qapi/block.json
> index 46955bbb3e3..456118eb0b4 100644
> --- a/qapi/block.json
> +++ b/qapi/block.json
> @@ -603,3 +603,25 @@
>             '*boundaries-zap': ['uint64'],
>             '*boundaries-flush': ['uint64'] },
>    'allow-preconfig': true }
> +
> +##
> +# @IoAccountingOperation:
> +#
> +# A more finely grained enumeration of I/O operation types beyond what
> +# `IoOperationType` provides (whose read/write distinction matches the
> +# rerror/werror policy settings).

Why is the comparison to IoOperationType useful?

If making the connection between IoOperationType values and
"rerror/werror policy setting" is useful, why isn't it made in
IoOperationType's docs?

What settings exactly?  Could this be a link?

> +#
> +# @read: Reading data
> +#
> +# @write: Writing data
> +#
> +# @flush: Flushing data to disk
> +#
> +# @zone-append: Appending data to a zone of a zoned block device
> +#
> +# @unmap: Discarding a block of data
> +#
> +# Since: 11.2
> +##
> +{ 'enum': 'IoAccountingOperation',
> +  'data': [ 'read', 'write', 'flush', 'zone-append', 'unmap' ] }